Bug 91689

Summary: [BlackBerry] Only maintain the hole punch rect while html5 video is being renderered
Product: WebKit Reporter: Max Feil <mfeil>
Component: WebKit BlackBerryAssignee: Max Feil <mfeil>
Status: CLOSED FIXED    
Severity: Normal CC: eric.carlson, feature-media-reviews, mifenton, tonikitoo, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Max Feil
Reported 2012-07-18 16:07:16 PDT
This is for PR160619. The hole punch rectangle needs to be present if and only if html5 video content is being rendered. Otherwise unwanted content may show through from behind the browser tab's window.
Attachments
Patch (2.96 KB, patch)
2012-07-18 16:15 PDT, Max Feil 		no flags
DetailsFormatted DiffDiff
Patch (2.96 KB, patch)
2012-07-19 11:52 PDT, Max Feil 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Max Feil
Comment 1 2012-07-18 16:15:28 PDT
Created attachment 153128 [details] Patch
Antonio Gomes
Comment 2 2012-07-19 07:58:37 PDT
Comment on attachment 153128 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=153128&action=review Good stuff Nit: comments in the code need period at the end. Please reupload with "Reviewed by Antonio Gomes" and only ask for commit-queue. No need to get it reviewed again. > Source/WebCore/platform/graphics/blackberry/MediaPlayerPrivateBlackBerry.cpp:512 > + // Remove media player from platform layer (removes hole punch rect) comments are real sentenses > Source/WebCore/platform/graphics/blackberry/MediaPlayerPrivateBlackBerry.cpp:525 > + // Create platform layer for video (creates hole punch rect) ditto
Max Feil
Comment 3 2012-07-19 11:52:10 PDT
Created attachment 153315 [details] Patch
Max Feil
Comment 4 2012-07-19 11:54:51 PDT
The only change in the latest patch is the addition of periods to the ends of comments, and setting "Antonio Gomes" as the reviewer in the changelog entry.
WebKit Review Bot
Comment 5 2012-07-19 12:49:01 PDT
Comment on attachment 153315 [details] Patch Clearing flags on attachment: 153315 Committed r123138: <http://trac.webkit.org/changeset/123138>
WebKit Review Bot
Comment 6 2012-07-19 12:49:13 PDT
All reviewed patches have been landed. Closing bug.
Max Feil
Comment 7 2012-11-02 12:50:53 PDT
Closing bug for patch that landed a long time ago.
Max Feil
Comment 8 2012-11-02 12:52:07 PDT
Closing bug for patch that landed a long time ago.
Note You need to log in before you can comment on or make changes to this bug.