Bug 91662

Summary: Prototype of media source time offset (not to be committed)
Product: WebKit Reporter: Victoria Kirst <vrk>
Component: New BugsAssignee: Victoria Kirst <vrk>
Status: RESOLVED WONTFIX    
Severity: Normal CC: abarth, dglazkov, eric.carlson, feature-media-reviews, fishd, jamesr, ojan, tkent+wkapi, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch vrk: review-, vrk: commit-queue-

Victoria Kirst
Reported 2012-07-18 13:08:23 PDT
Prototype of media source time offset (not to be committed)
Attachments
Patch (11.12 KB, patch)
2012-07-18 13:17 PDT, Victoria Kirst 		vrk: review-
vrk: commit-queue-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Victoria Kirst
Comment 1 2012-07-18 13:17:01 PDT
Reopening to attach new patch.
Victoria Kirst
Comment 2 2012-07-18 13:17:02 PDT
Created attachment 153074 [details] Patch
WebKit Review Bot
Comment 3 2012-07-18 13:18:11 PDT
Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org or tkent@chromium.org before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI.
Victoria Kirst
Comment 4 2012-07-18 13:20:16 PDT
Prototype code that's not meant for review. Should be used in conjunction with the following chromium CL: https://chromiumcodereview.appspot.com/10803019/ Prototyping an implementation of timestamp offset for MediaSource.
Eric Carlson
Comment 5 2012-07-18 13:24:07 PDT
> Source/WebCore/ChangeLog:8 > + Prototype of media source time offset (not to be committed) > + https://bugs.webkit.org/show_bug.cgi?id=91662 > + > + Reviewed by NOBODY (OOPS!). > + > + Additional information of the change such as approach, rationale. Please add per-function descriptions below (OOPS!). What is motivating these changes? Where are the per-function descriptions? > Source/WebCore/html/HTMLMediaElement.idl:106 > + /// VRK's HACK !!! What is this?
Victoria Kirst
Comment 6 2012-07-18 13:27:35 PDT
(In reply to comment #5) > > Source/WebCore/ChangeLog:8 > > + Prototype of media source time offset (not to be committed) > > + https://bugs.webkit.org/show_bug.cgi?id=91662 > > + > > + Reviewed by NOBODY (OOPS!). > > + > > + Additional information of the change such as approach, rationale. Please add per-function descriptions below (OOPS!). > > What is motivating these changes? Where are the per-function descriptions? > > > Source/WebCore/html/HTMLMediaElement.idl:106 > > + /// VRK's HACK !!! > > What is this? Sorry Eric!! Didn't mean for this to be reviewed or committed - just wanted to show the CL to a teammate (acolwell@). I didn't realize it would auto-CC everyone and send a bunch of emails!
Eric Carlson
Comment 7 2012-07-18 13:31:53 PDT
(In reply to comment #6) > > Sorry Eric!! Didn't mean for this to be reviewed or committed - just wanted to show the CL to a teammate (acolwell@). I didn't realize it would auto-CC everyone and send a bunch of emails! No worries! YOu might want to try the "show-pretty-diff" tools to create formatted diff files, I use it all the time when I want to send a WIP patch to someone via email.
Note You need to log in before you can comment on or make changes to this bug.