Summary: | [Chromium] Support external autofill popups | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Peter Beverloo <peter> | ||||||||
Component: | WebKit API | Assignee: | Adam Barth <abarth> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | abarth, dglazkov, fishd, jamesr, jrg, tkent+wkapi, webkit.review.bot | ||||||||
Priority: | P2 | ||||||||||
Version: | 528+ (Nightly build) | ||||||||||
Hardware: | Unspecified | ||||||||||
OS: | Unspecified | ||||||||||
Bug Depends on: | |||||||||||
Bug Blocks: | 91648 | ||||||||||
Attachments: |
|
Description
Peter Beverloo
2012-07-18 12:34:18 PDT
To save other folks the research, I think what's left here is WebView::selectAutofillSuggestionAtIndex Created attachment 153338 [details]
work in progress
Created attachment 153347 [details]
Patch
Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org or tkent@chromium.org before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI. Comment on attachment 153347 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=153347&action=review > Source/WebKit/chromium/ChangeLog:8 > + This looks like the last piece of needed to support external autofill nit: "last piece [--of--] needed to support external" > Source/WebKit/chromium/ChangeLog:9 > + popups. This funtion just lets the embedder select an index (presumably nit: funtion -> function Created attachment 153359 [details]
Patch for landing
Comment on attachment 153359 [details] Patch for landing Clearing flags on attachment: 153359 Committed r123160: <http://trac.webkit.org/changeset/123160> All reviewed patches have been landed. Closing bug. |