Summary: | Roll out r121610 and r122487 which may have been causing flaky crashes | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Joshua Bell <jsbell> | ||||
Component: | New Bugs | Assignee: | Joshua Bell <jsbell> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | abarth, haraken, japhet, jochen, webkit.review.bot, wez | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Bug Depends on: | 90469 | ||||||
Bug Blocks: | |||||||
Attachments: |
|
Description
Joshua Bell
2012-07-18 10:22:32 PDT
I don't have strong evidence that r121610 is behind the flakes described in webkit.org/b/90469 but we should rule it out. Will upload a patch here once I've got a try run. Created attachment 153047 [details]
Patch
Comment on attachment 153047 [details]
Patch
OK. Try it.
Attachment 153047 [details] did not pass style-queue:
Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/plug..." exit_code: 1
Source/WebCore/bindings/v8/NPObjectWrapper.cpp:151: Place brace on its own line for function definitions. [whitespace/braces] [4]
Source/WebCore/bindings/v8/NPObjectWrapper.cpp:176: One line control clauses should not use braces. [whitespace/braces] [4]
Source/WebCore/bindings/v8/NPObjectWrapper.cpp:174: An else statement can be removed when the prior "if" concludes with a return, break, continue or goto statement. [readability/control_flow] [4]
Source/WebCore/bindings/v8/NPObjectWrapper.cpp:178: One line control clauses should not use braces. [whitespace/braces] [4]
Source/WebCore/bindings/v8/ScriptController.cpp:48: Alphabetical sorting problem. [build/include_order] [4]
Source/WebCore/bindings/v8/NPObjectWrapper.h:46: The parameter name "object" adds no information, so it should be removed. [readability/parameter_name] [5]
Source/WebCore/bindings/v8/NPObjectWrapper.h:52: The parameter name "obj" adds no information, so it should be removed. [readability/parameter_name] [5]
Source/WebCore/bindings/v8/NPObjectWrapper.h:56: The parameter name "obj" adds no information, so it should be removed. [readability/parameter_name] [5]
Source/WebCore/bindings/v8/NPObjectWrapper.h:60: The parameter name "obj" adds no information, so it should be removed. [readability/parameter_name] [5]
Source/WebCore/bindings/v8/NPObjectWrapper.h:61: The parameter name "obj" adds no information, so it should be removed. [readability/parameter_name] [5]
Source/WebCore/bindings/v8/NPObjectWrapper.h:62: The parameter name "obj" adds no information, so it should be removed. [readability/parameter_name] [5]
Source/WebCore/bindings/v8/NPObjectWrapper.h:63: The parameter name "obj" adds no information, so it should be removed. [readability/parameter_name] [5]
Source/WebCore/bindings/v8/NPObjectWrapper.h:64: The parameter name "obj" adds no information, so it should be removed. [readability/parameter_name] [5]
Source/WebCore/bindings/v8/NPObjectWrapper.h:65: The parameter name "obj" adds no information, so it should be removed. [readability/parameter_name] [5]
Source/WebCore/bindings/v8/NPObjectWrapper.h:66: The parameter name "obj" adds no information, so it should be removed. [readability/parameter_name] [5]
Source/WebCore/bindings/v8/NPObjectWrapper.h:67: The parameter name "obj" adds no information, so it should be removed. [readability/parameter_name] [5]
Source/WebCore/bindings/v8/NPObjectWrapper.h:68: The parameter name "obj" adds no information, so it should be removed. [readability/parameter_name] [5]
Source/WebCore/bindings/v8/NPObjectWrapper.h:69: The parameter name "obj" adds no information, so it should be removed. [readability/parameter_name] [5]
Source/WebCore/bindings/v8/NPObjectWrapper.h:70: The parameter name "obj" adds no information, so it should be removed. [readability/parameter_name] [5]
Source/WebCore/bindings/v8/NPObjectWrapper.h:71: The parameter name "npp" adds no information, so it should be removed. [readability/parameter_name] [5]
Source/WebCore/bindings/v8/NPObjectWrapper.h:71: The parameter name "obj" adds no information, so it should be removed. [readability/parameter_name] [5]
Source/WebCore/bindings/v8/NPObjectWrapper.h:71: Missing space after , [whitespace/comma] [3]
Source/WebCore/bindings/v8/NPObjectWrapper.h:74: The parameter name "obj" adds no information, so it should be removed. [readability/parameter_name] [5]
Source/WebCore/bindings/v8/NPObjectWrapper.h:78: The parameter name "obj" adds no information, so it should be removed. [readability/parameter_name] [5]
Total errors found: 24 in 12 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Maybe you need to land it manually to avoid style check errors. Landed manually as r123110: http://trac.webkit.org/changeset/123110 ... and looking promising. 0 of the 17 runs have shown flaky crashes in the "s*" layout tests after the patch landing, compared to a roughly 95% showing a flaky crash prior to that revision. Will give it a day before updating TestExpectations, though. |