Summary: | [WK2][EFL] Add a common code using Color instead of QColor | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | YoungTaeck Song <youngtaeck.song> | ||||||||
Component: | WebKit EFL | Assignee: | Nobody <webkit-unassigned> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | gyuyoung.kim, hausmann, lucas.de.marchi, noam, webkit.review.bot | ||||||||
Priority: | P2 | ||||||||||
Version: | 528+ (Nightly build) | ||||||||||
Hardware: | Other | ||||||||||
OS: | Linux | ||||||||||
Attachments: |
|
Attachment 152917 [details] did not pass style-queue:
Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit2/ChangeLog', u'Source/WebKit..." exit_code: 1
Source/WebKit2/ChangeLog:1: ChangeLog entry has no bug number [changelog/bugnumber] [5]
Total errors found: 1 in 2 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 152924 [details]
patch
miss bug number
Comment on attachment 152924 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=152924&action=review > Source/WebKit2/UIProcess/texmap/LayerBackingStore.cpp:149 > +#if PLATFORM(QT) > textureMapper->drawBorder(QColor(Qt::red), 2, tile->rect(), transform); > +#else > + textureMapper->drawBorder(Color(Color::lightGray), 2, tile->rect(), transform); > +#endif I think it would be better to _replace_ the use of QColor with Color (and either stick to lightGray or add red to Color::). Let's avoid #ifdefs if we can :) Created attachment 152962 [details]
Patch
(In reply to comment #3) > (From update of attachment 152924 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=152924&action=review > > > Source/WebKit2/UIProcess/texmap/LayerBackingStore.cpp:149 > > +#if PLATFORM(QT) > > textureMapper->drawBorder(QColor(Qt::red), 2, tile->rect(), transform); > > +#else > > + textureMapper->drawBorder(Color(Color::lightGray), 2, tile->rect(), transform); > > +#endif > > I think it would be better to _replace_ the use of QColor with Color (and either stick to lightGray or add red to Color::). Let's avoid #ifdefs if we can :) Thank you for kind review. There is no Color::red in Color.h. So I used Color(0xFF, 0, 0). Comment on attachment 152962 [details] Patch Clearing flags on attachment: 152962 Committed r122941: <http://trac.webkit.org/changeset/122941> All reviewed patches have been landed. Closing bug. |
Created attachment 152917 [details] patch This patch is a subset of Efl's UI_SIDE_COMPOSITING implementation. drawBorder's argument is QColor. So add a common code using Color to be used by Efl.