Bug 91539

Summary:

Remove NRWT --shard-ref-tests once --pixel-tests argument can be passed as a per-test-arg

Product:

WebKit

Reporter:

Xianzhu Wang <wangxianzhu>

Component:

Tools / Tests

Assignee:

Xianzhu Wang <wangxianzhu>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

abarth, dpranke, ojan, webkit.review.bot

Priority:

Keywords:

NRWT

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

91538

Bug Blocks:

Attachments:

Description	Flags
Patch	none

Description Xianzhu Wang 2012-07-17 13:45:45 PDT

Bug 91533 adds --shard-ref-tests to reduce the cost of restarting the driver/DRT when switching between pixel mode and non-pixel mode. After we have --pixel-tests passed as a per-test arg to DRT, we can have one driver/DRT instance supporting both pixel and non-pixel tests, so the --shard-ref-tests will be unnecessary.

Comment 1 Xianzhu Wang 2012-08-06 13:39:06 PDT

Created attachment 156755 [details]
Patch

Comment 2 Xianzhu Wang 2012-08-06 13:41:26 PDT

I wish I'd not have made the change for bug 91533 :)

Comment 3 Dirk Pranke 2012-08-06 13:41:50 PDT

Comment on attachment 156755 [details]
Patch

yay for deleting code :).

Comment 4 WebKit Review Bot 2012-08-06 16:20:13 PDT

Comment on attachment 156755 [details]
Patch

Clearing flags on attachment: 156755

Committed r124809: <http://trac.webkit.org/changeset/124809>

Comment 5 WebKit Review Bot 2012-08-06 16:20:17 PDT

All reviewed patches have been landed.  Closing bug.