Bug 91522

Summary: Add MIPS add32 function
Product: WebKit Reporter: Chao-ying Fu <fu>
Component: JavaScriptCoreAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: Linux   
Attachments:
Description Flags
MIPS add32 function
ap: commit-queue-
Update ChangeLog to include descriptions
none
Add MIPS isCompactPtrAlignedAddressOffset and add32 none

Chao-ying Fu
Reported 2012-07-17 10:44:21 PDT
Hi, I will post a patch to add "add32" function. Thanks!
Attachments
MIPS add32 function (1.37 KB, patch)
2012-07-17 10:48 PDT, Chao-ying Fu 		ap: commit-queue-
DetailsFormatted DiffDiff
Update ChangeLog to include descriptions (1.36 KB, patch)
2012-07-18 13:36 PDT, Chao-ying Fu 		no flags
DetailsFormatted DiffDiff
Add MIPS isCompactPtrAlignedAddressOffset and add32 (1.77 KB, patch)
2012-07-25 16:04 PDT, Chao-ying Fu 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Chao-ying Fu
Comment 1 2012-07-17 10:48:56 PDT
Created attachment 152785 [details] MIPS add32 function Here is the patch. The jsc testing is ok. Thanks!
Alexey Proskuryakov
Comment 2 2012-07-18 12:08:14 PDT
Comment on attachment 152785 [details] MIPS add32 function View in context: https://bugs.webkit.org/attachment.cgi?id=152785&action=review > Source/JavaScriptCore/ChangeLog:8 > + Additional information of the change such as approach, rationale. Please add per-function descriptions below (OOPS!). Please write a brief description, as requested here.
Chao-ying Fu
Comment 3 2012-07-18 13:36:12 PDT
Created attachment 153078 [details] Update ChangeLog to include descriptions Hi, I updated ChangeLog to include descriptions. Thanks!
Chao-ying Fu
Comment 4 2012-07-25 16:04:14 PDT
Created attachment 154470 [details] Add MIPS isCompactPtrAlignedAddressOffset and add32 I added the "isCompactPtrAlignedAddressOffset" function to fix the MIPS build. The JSC testing is OK. Thanks a lot!
WebKit Review Bot
Comment 5 2012-07-31 11:44:21 PDT
Comment on attachment 154470 [details] Add MIPS isCompactPtrAlignedAddressOffset and add32 Clearing flags on attachment: 154470 Committed r124228: <http://trac.webkit.org/changeset/124228>
WebKit Review Bot
Comment 6 2012-07-31 11:44:24 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.