Bug 91513

Summary: Web Inspector: create timeline detail records lazily
Product: WebKit Reporter: Andrey Kosyakov <caseq>
Component: Web Inspector (Deprecated)Assignee: Andrey Kosyakov <caseq>
Status: RESOLVED FIXED    
Severity: Normal CC: apavlov, bweinstein, joepeck, keishi, loislo, pfeldman, pmuellr, rik, timothy, yurys
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch pfeldman: review+

Andrey Kosyakov
Reported 2012-07-17 10:06:51 PDT
Timeline record details include linkified locations, which are rather large. I'm getting a reduction from 132M to 117M in heap sizes by not creating record details until these are used.
Attachments
Patch (1.62 KB, patch)
2012-07-17 10:07 PDT, Andrey Kosyakov 		pfeldman: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Andrey Kosyakov
Comment 1 2012-07-17 10:07:59 PDT
Created attachment 152775 [details] Patch
Pavel Feldman
Comment 2 2012-07-17 13:11:00 PDT
Comment on attachment 152775 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=152775&action=review > Source/WebCore/inspector/front-end/TimelinePresentationModel.js:633 > + get details() Please annotate. Also, please use functions where possible since they are more compiler-friendly.
Andrey Kosyakov
Comment 3 2012-07-18 05:39:08 PDT
Committed r122950: <http://trac.webkit.org/changeset/122950>
Note You need to log in before you can comment on or make changes to this bug.