Bug 91499

Summary: double data type shoud be changed to float in ColorMatrix
Product: WebKit Reporter: Tamas Czene <tczene>
Component: SVGAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: ap, thorton, webkit.review.bot, zherczeg, zimmermann
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
proposed patch none

Tamas Czene
Reported 2012-07-17 06:18:40 PDT
According to tests double type is unnecessary. SVG Filters use float type everywhere so we shoud change double to float.
Attachments
proposed patch (5.48 KB, patch)
2012-07-17 06:24 PDT, Tamas Czene 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Tamas Czene
Comment 1 2012-07-17 06:24:03 PDT
Created attachment 152751 [details] proposed patch
Alexey Proskuryakov
Comment 2 2012-07-18 12:27:43 PDT
What is the expected benefit of this change? Is it matching other code, or something else?
Tamas Czene
Comment 3 2012-07-19 01:31:41 PDT
Opengl ES 2.0, ARM NEON, OpenCL don't support double type.
Alexey Proskuryakov
Comment 4 2012-07-19 08:52:29 PDT
Please elaborate. This patch changes C++ code, not OpenGL or OpenCL.
Tamas Czene
Comment 5 2012-07-20 07:01:36 PDT
For this filter doesn't need double precision and it confused me when I implemented the opencl/gl version. The goal is to uniform the codes.
Alexey Proskuryakov
Comment 6 2012-07-20 09:21:38 PDT
Thank you for the explanation. I'll leave final review to someone better familiar with this code, and with performance characteristics of double vs. float on modern processors.
Nikolas Zimmermann
Comment 7 2012-07-20 22:50:28 PDT
Comment on attachment 152751 [details] proposed patch Looks okay to me - all tests still pass, so we're not affected by precision issues, so rs=me.
WebKit Review Bot
Comment 8 2012-07-20 23:07:34 PDT
Comment on attachment 152751 [details] proposed patch Clearing flags on attachment: 152751 Committed r123288: <http://trac.webkit.org/changeset/123288>
WebKit Review Bot
Comment 9 2012-07-20 23:07:39 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.