Bug 91471

Summary: Internals: Remove injectPagePopupController()
Product: WebKit Reporter: Kent Tamura <tkent>
Component: Tools / TestsAssignee: Kent Tamura <tkent>
Status: RESOLVED FIXED    
Severity: Normal CC: morrita, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch 2 none

Kent Tamura
Reported 2012-07-16 23:27:03 PDT
http://trac.webkit.org/changeset/122558 introduced injectPagePopupController(), however we'd like to avoid adding such JavaScript binding code. https://bugs.webkit.org/show_bug.cgi?id=84827#c23
Attachments
Patch (10.59 KB, patch)
2012-07-16 23:36 PDT, Kent Tamura 		no flags
DetailsFormatted DiffDiff
Patch 2 (10.74 KB, patch)
2012-07-16 23:59 PDT, Kent Tamura 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Kent Tamura
Comment 1 2012-07-16 23:36:03 PDT
Created attachment 152703 [details] Patch
Build Bot
Comment 2 2012-07-16 23:50:57 PDT
Comment on attachment 152703 [details] Patch Attachment 152703 [details] did not pass mac-ews (mac): Output: http://queues.webkit.org/results/13275063
Kent Tamura
Comment 3 2012-07-16 23:59:15 PDT
Created attachment 152704 [details] Patch 2 Mac build fix
Hajime Morrita
Comment 4 2012-07-17 00:17:27 PDT
Comment on attachment 152704 [details] Patch 2 Thanks for taking this.
WebKit Review Bot
Comment 5 2012-07-17 01:22:29 PDT
Comment on attachment 152704 [details] Patch 2 Clearing flags on attachment: 152704 Committed r122823: <http://trac.webkit.org/changeset/122823>
WebKit Review Bot
Comment 6 2012-07-17 01:22:33 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.