Bug 91464

Summary: vertical-align: middle causes overflow with subpixel layout
Product: WebKit Reporter: Emil A Eklund <eae>
Component: Layout and RenderingAssignee: Emil A Eklund <eae>
Status: RESOLVED FIXED    
Severity: Normal CC: d-r, eric, jer.noble
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Emil A Eklund
Reported 2012-07-16 19:34:38 PDT
Using vertical-align: middle in combination with an overflow value other than visible can cause the overflow height to be computed incorrectly. Downstream chromium bug: http://code.google.com/p/chromium/issues/detail?id=130888
Attachments
Patch (111.80 KB, patch)
2012-07-17 11:12 PDT, Emil A Eklund 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Emil A Eklund
Comment 1 2012-07-17 11:12:49 PDT
Created attachment 152789 [details] Patch
Eric Seidel (no email)
Comment 2 2012-07-17 11:49:42 PDT
Comment on attachment 152789 [details] Patch OK.
Emil A Eklund
Comment 3 2012-07-17 15:51:53 PDT
Committed r122883: <http://trac.webkit.org/changeset/122883>
Jer Noble
Comment 4 2012-07-18 16:54:53 PDT
The platform/mac/fast/inline/002-expected.txt and platform/mac/fast/table/table-display-types-strict-expected.txt files added by this commit have been broken since they were committed on the Apple Lion bots. See: http://build.webkit.org/results/Apple%20Lion%20Release%20WK1%20(Tests)/r122883%20(1232)/results.html http://build.webkit.org/results/Apple%20Lion%20Release%20WK1%20(Tests)/r122883%20(1232)/fast/inline/002-pretty-diff.html http://build.webkit.org/results/Apple%20Lion%20Release%20WK1%20(Tests)/r122883%20(1232)/fast/table/table-display-types-strict-pretty-diff.html
Emil A Eklund
Comment 5 2012-07-18 16:56:49 PDT
(In reply to comment #4) > The platform/mac/fast/inline/002-expected.txt and platform/mac/fast/table/table-display-types-strict-expected.txt files added by this commit have been broken since they were committed on the Apple Lion bots. > > See: > http://build.webkit.org/results/Apple%20Lion%20Release%20WK1%20(Tests)/r122883%20(1232)/results.html > http://build.webkit.org/results/Apple%20Lion%20Release%20WK1%20(Tests)/r122883%20(1232)/fast/inline/002-pretty-diff.html > http://build.webkit.org/results/Apple%20Lion%20Release%20WK1%20(Tests)/r122883%20(1232)/fast/table/table-display-types-strict-pretty-diff.html Sorry about that, looking into it now.
Jer Noble
Comment 6 2012-07-18 17:34:16 PDT
Reverted the changes to the platform/mac expected results in http://trac.webkit.org/changeset/123053.
Emil A Eklund
Comment 7 2012-07-18 19:21:34 PDT
Thank you.
Dominik Röttsches (drott)
Comment 8 2012-07-19 02:11:47 PDT
*** Bug 90169 has been marked as a duplicate of this bug. ***
Note You need to log in before you can comment on or make changes to this bug.