Bug 91464

Summary:

vertical-align: middle causes overflow with subpixel layout

Product:

WebKit

Reporter:

Emil A Eklund <eae>

Component:

Layout and Rendering

Assignee:

Emil A Eklund <eae>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

d-r, eric, jer.noble

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none

Description Emil A Eklund 2012-07-16 19:34:38 PDT

Using vertical-align: middle in combination with an overflow value other than visible can cause the overflow height to be computed incorrectly.

Downstream chromium bug: http://code.google.com/p/chromium/issues/detail?id=130888

Comment 1 Emil A Eklund 2012-07-17 11:12:49 PDT

Created attachment 152789 [details]
Patch

Comment 2 Eric Seidel (no email) 2012-07-17 11:49:42 PDT

Comment on attachment 152789 [details]
Patch

OK.

Comment 3 Emil A Eklund 2012-07-17 15:51:53 PDT

Committed r122883: <http://trac.webkit.org/changeset/122883>

Comment 4 Jer Noble 2012-07-18 16:54:53 PDT

The platform/mac/fast/inline/002-expected.txt and platform/mac/fast/table/table-display-types-strict-expected.txt files added by this commit have been broken since they were committed on the Apple Lion bots.

See:
http://build.webkit.org/results/Apple%20Lion%20Release%20WK1%20(Tests)/r122883%20(1232)/results.html
http://build.webkit.org/results/Apple%20Lion%20Release%20WK1%20(Tests)/r122883%20(1232)/fast/inline/002-pretty-diff.html
http://build.webkit.org/results/Apple%20Lion%20Release%20WK1%20(Tests)/r122883%20(1232)/fast/table/table-display-types-strict-pretty-diff.html

Comment 5 Emil A Eklund 2012-07-18 16:56:49 PDT

(In reply to comment #4)
> The platform/mac/fast/inline/002-expected.txt and platform/mac/fast/table/table-display-types-strict-expected.txt files added by this commit have been broken since they were committed on the Apple Lion bots.
> 
> See:
> http://build.webkit.org/results/Apple%20Lion%20Release%20WK1%20(Tests)/r122883%20(1232)/results.html
> http://build.webkit.org/results/Apple%20Lion%20Release%20WK1%20(Tests)/r122883%20(1232)/fast/inline/002-pretty-diff.html
> http://build.webkit.org/results/Apple%20Lion%20Release%20WK1%20(Tests)/r122883%20(1232)/fast/table/table-display-types-strict-pretty-diff.html

Sorry about that, looking into it now.

Comment 6 Jer Noble 2012-07-18 17:34:16 PDT

Reverted the changes to the platform/mac expected results in http://trac.webkit.org/changeset/123053.

Comment 7 Emil A Eklund 2012-07-18 19:21:34 PDT

Thank you.

Comment 8 Dominik Röttsches (drott) 2012-07-19 02:11:47 PDT

*** Bug 90169 has been marked as a duplicate of this bug. ***