Bug 91447

Summary:

nrwt: clean up logging when we're only running one chunk of the tests

Product:

WebKit

Reporter:

Dirk Pranke <dpranke>

Component:

New Bugs

Assignee:

Dirk Pranke <dpranke>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

abarth, eric, ojan, tony

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	ojan: review+

Description Dirk Pranke 2012-07-16 17:05:23 PDT

nrwt: clean up logging when we're only running one chunk of the tests

Comment 1 Dirk Pranke 2012-07-16 17:06:41 PDT

Created attachment 152647 [details]
Patch

Comment 2 Ojan Vafai 2012-07-17 13:34:17 PDT

Comment on attachment 152647 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=152647&action=review

> Tools/Scripts/webkitpy/layout_tests/controllers/manager.py:-431
> -        tests_run_filename = self._filesystem.join(self._results_directory, "tests_run.txt")

The valgrind layout tests bots used to use this IIRC in order to know which chunk to run next. I suppose we can get rid of it for now since noone seems to be using it. I suppose it's silly for this to be in RWT. The bot itself should just read the stdio log and maintain this information itself if it needs it.

Comment 3 Dirk Pranke 2012-07-17 16:18:58 PDT

Committed r122892: <http://trac.webkit.org/changeset/122892>