Bug 91447

Summary: nrwt: clean up logging when we're only running one chunk of the tests
Product: WebKit Reporter: Dirk Pranke <dpranke>
Component: New BugsAssignee: Dirk Pranke <dpranke>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, eric, ojan, tony
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch ojan: review+

Dirk Pranke
Reported 2012-07-16 17:05:23 PDT
nrwt: clean up logging when we're only running one chunk of the tests
Attachments
Patch (2.68 KB, patch)
2012-07-16 17:06 PDT, Dirk Pranke 		ojan: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Dirk Pranke
Comment 1 2012-07-16 17:06:41 PDT
Created attachment 152647 [details] Patch
Ojan Vafai
Comment 2 2012-07-17 13:34:17 PDT
Comment on attachment 152647 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=152647&action=review > Tools/Scripts/webkitpy/layout_tests/controllers/manager.py:-431 > - tests_run_filename = self._filesystem.join(self._results_directory, "tests_run.txt") The valgrind layout tests bots used to use this IIRC in order to know which chunk to run next. I suppose we can get rid of it for now since noone seems to be using it. I suppose it's silly for this to be in RWT. The bot itself should just read the stdio log and maintain this information itself if it needs it.
Dirk Pranke
Comment 3 2012-07-17 16:18:58 PDT
Committed r122892: <http://trac.webkit.org/changeset/122892>
Note You need to log in before you can comment on or make changes to this bug.