Bug 91414

Summary: IndexedDB: Include intVersion when converting between WebCore and WebKit IDBMetadata types
Product: WebKit Reporter: David Grogan <dgrogan>
Component: New BugsAssignee: David Grogan <dgrogan>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, alecflett, jsbell, webkit.review.bot
Priority: P2    
Version: 312.x   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 91408    
Bug Blocks:    
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch
none
Patch
none
Patch
none
Patch for landing none

David Grogan
Reported 2012-07-16 12:30:40 PDT
IndexedDB: Include intVersion when converting between WebCore and WebKit IDBMetadata types
Attachments
Patch (4.62 KB, patch)
2012-07-16 12:32 PDT, David Grogan 		no flags
DetailsFormatted DiffDiff
Patch (5.84 KB, patch)
2012-07-16 14:24 PDT, David Grogan 		no flags
DetailsFormatted DiffDiff
Patch (5.93 KB, patch)
2012-07-16 14:28 PDT, David Grogan 		no flags
DetailsFormatted DiffDiff
Patch (6.77 KB, patch)
2012-07-16 14:32 PDT, David Grogan 		no flags
DetailsFormatted DiffDiff
Patch (6.00 KB, patch)
2012-07-17 16:13 PDT, David Grogan 		no flags
DetailsFormatted DiffDiff
Patch (5.93 KB, patch)
2012-07-18 18:40 PDT, David Grogan 		no flags
DetailsFormatted DiffDiff
Patch for landing (5.89 KB, patch)
2012-07-20 13:33 PDT, David Grogan 		no flags
DetailsFormatted DiffDiff
Show Obsolete (6) View All Add attachment proposed patch, testcase, etc.
David Grogan
Comment 1 2012-07-16 12:32:23 PDT
Created attachment 152587 [details] Patch
WebKit Review Bot
Comment 2 2012-07-16 12:56:51 PDT
Comment on attachment 152587 [details] Patch Attachment 152587 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/13262069
David Grogan
Comment 3 2012-07-16 13:18:14 PDT
This won't pass cr-linux until 91408 lands.
David Grogan
Comment 4 2012-07-16 14:24:56 PDT
Created attachment 152611 [details] Patch
David Grogan
Comment 5 2012-07-16 14:28:18 PDT
Created attachment 152612 [details] Patch
David Grogan
Comment 6 2012-07-16 14:32:42 PDT
Created attachment 152614 [details] Patch
WebKit Review Bot
Comment 7 2012-07-16 14:34:01 PDT
Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org or tkent@chromium.org before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI.
David Grogan
Comment 8 2012-07-17 16:13:43 PDT
Created attachment 152862 [details] Patch
David Grogan
Comment 9 2012-07-18 18:40:26 PDT
Created attachment 153155 [details] Patch
David Grogan
Comment 10 2012-07-18 18:42:44 PDT
Josh or Alec, could you take a look at this?
Joshua Bell
Comment 11 2012-07-20 09:19:03 PDT
Comment on attachment 153155 [details] Patch LGTM. Having intVersion be an optional add-on in the API rather than the new default (and thus making the legacy string version optional) means there will be more "clean up" work later on, but this is probably the safest incremental approach to get the new support in and under test.
Joshua Bell
Comment 12 2012-07-20 09:23:00 PDT
abarth@ can you r?
Adam Barth
Comment 13 2012-07-20 09:26:56 PDT
Comment on attachment 153155 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=153155&action=review > Source/WebCore/Modules/indexeddb/IDBMetadata.h:50 > + : intVersion(NoIntVersion) { } The { } should each be on their own line.
David Grogan
Comment 14 2012-07-20 13:33:14 PDT
Created attachment 153585 [details] Patch for landing
David Grogan
Comment 15 2012-07-20 13:33:48 PDT
Comment on attachment 153155 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=153155&action=review Adam and Josh, thanks for the review. >> Source/WebCore/Modules/indexeddb/IDBMetadata.h:50 >> + : intVersion(NoIntVersion) { } > > The { } should each be on their own line. Done.
WebKit Review Bot
Comment 16 2012-07-20 14:56:22 PDT
Comment on attachment 153585 [details] Patch for landing Clearing flags on attachment: 153585 Committed r123267: <http://trac.webkit.org/changeset/123267>
WebKit Review Bot
Comment 17 2012-07-20 14:56:27 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.