Bug 91410 – Inconsistent rounding in table layout causes background color to bleed through

• Component: Layout and Rendering
• Status: RESOLVED FIXED

[Emil A Eklund]

At certain zoom levels a rounding error in the table layout code cases the table background color to bleed through between cells. 

This only affects platforms that have enabled sub-pixel layout.

Downstream chromium bug: http://code.google.com/p/chromium/issues/detail?id=137191

[Emil A Eklund]

Created attachment 152581 [details]
Patch

[WebKit Review Bot]

Comment on attachment 152581 [details]
Patch

Attachment 152581 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/13260120

New failing tests:
css1/basic/inheritance.html
svg/zoom/page/zoom-svg-through-object-with-absolute-size.xhtml
svg/zoom/page/zoom-img-preserveAspectRatio-support-1.html
svg/zoom/page/zoom-replaced-intrinsic-ratio-001.htm
svg/zoom/page/zoom-svg-through-object-with-percentage-size.xhtml
svg/zoom/page/zoom-svg-through-object-with-absolute-size-2.xhtml
tables/mozilla/bugs/bug73321.html

[WebKit Review Bot]

Created attachment 152604 [details]
Archive of layout-test-results from gce-cr-linux-05

The attached test failures were seen while running run-webkit-tests on the chromium-ews.
Bot: gce-cr-linux-05  Port: <class 'webkitpy.common.config.ports.ChromiumXVFBPort'>  Platform: Linux-2.6.39-gcg-201203291735-x86_64-with-Ubuntu-10.04-lucid

[Emil A Eklund]

Created attachment 152608 [details]
Patch

[Emil A Eklund]

The eseidel is back! Thanks Eric.

[Eric Seidel (no email)]

Where did I go? :)

I guess I've just not been hunting the r? queue much these last couple weeks.

In any case, I'm here for your reviewing pleasure, just let me know.

[WebKit Review Bot]

Comment on attachment 152608 [details]
Patch

Attachment 152608 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/13268001

New failing tests:
plugins/embed-attributes-style.html
svg/zoom/page/zoom-replaced-intrinsic-ratio-001.htm

[WebKit Review Bot]

Created attachment 152621 [details]
Archive of layout-test-results from gce-cr-linux-02

The attached test failures were seen while running run-webkit-tests on the chromium-ews.
Bot: gce-cr-linux-02  Port: <class 'webkitpy.common.config.ports.ChromiumXVFBPort'>  Platform: Linux-2.6.39-gcg-201203291735-x86_64-with-Ubuntu-10.04-lucid

[Emil A Eklund]

Committed r122769: <http://trac.webkit.org/changeset/122769>

[Jer Noble]

This commit broke the fast/sub-pixel/selection/selection-gaps-at-fractional-offsets.html test on every platform which had previously skipped it by removing the "/selection/" from each Skipped list entry containing the test.

[Jer Noble]

Fixed in http://trac.webkit.org/changeset/123046.

[Emil A Eklund]

My bad, thank you!