Bug 91370 – run-webkit-test returns 254 at exit even when it succeeds

• Component: Tools / Tests
• Status: RESOLVED FIXED

[Thiago Marcos P. Santos]

Which makes impossible to make our bots green.

[Thiago Marcos P. Santos]

Created attachment 152505 [details]
Patch

[Chris Dumez]

Comment on attachment 152505 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=152505&action=review

> Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py:486
>      except BaseException, e:

Shouldn't we catch Exception instead of BaseException ?

[Thiago Marcos P. Santos]

(In reply to comment #2)
> (From update of attachment 152505 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=152505&action=review
> 
> > Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py:486
> >      except BaseException, e:
> 
> Shouldn't we catch Exception instead of BaseException ?

Check bug 91129.

[Thiago Marcos P. Santos]

Created attachment 152522 [details]
Patch

Better name to return code variable.

[Build Bot]

Comment on attachment 152522 [details]
Patch

Attachment 152522 [details] did not pass win-ews (win):
Output: http://queues.webkit.org/results/13238934

[WebKit Review Bot]

Comment on attachment 152522 [details]
Patch

Clearing flags on attachment: 152522

Committed r122728: <http://trac.webkit.org/changeset/122728>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.

[Dirk Pranke]

Comment on attachment 152522 [details]
Patch

interesting, I didn't realize that (obviously). Thanks for the fix!

[Dirk Pranke]

*** Bug 91389 has been marked as a duplicate of this bug. ***

[Vsevolod Vlasov]

webkit_lint is still red on chromium bots.

http://build.chromium.org/p/chromium.webkit/waterfall?branch=&builder=Webkit+Win+Builder&builder=Webkit+Win&builder=Webkit+Vista&builder=Webkit+Win7&builder=Webkit+Mac+Builder&builder=Webkit+Mac10.5&builder=Webkit+Mac10.6&builder=Webkit+Mac+Builder+%28CG%29&builder=Webkit+Mac10.5+%28CG%29&builder=Webkit+Mac10.6+%28CG%29&builder=Webkit+Mac10.7&builder=Webkit+Linux&builder=Webkit+Linux+32&reload=none

[Thiago Marcos P. Santos]

(In reply to comment #10)
> webkit_lint is still red on chromium bots.
> 
> http://build.chromium.org/p/chromium.webkit/waterfall?branch=&builder=Webkit+Win+Builder&builder=Webkit+Win&builder=Webkit+Vista&builder=Webkit+Win7&builder=Webkit+Mac+Builder&builder=Webkit+Mac10.5&builder=Webkit+Mac10.6&builder=Webkit+Mac+Builder+%28CG%29&builder=Webkit+Mac10.5+%28CG%29&builder=Webkit+Mac10.6+%28CG%29&builder=Webkit+Mac10.7&builder=Webkit+Linux&builder=Webkit+Linux+32&reload=none

IMO the actual failure is unrelated to this bug. Looks to me it is failing because of this:

LayoutTests/platform/chromium/TestExpectations:2885 More specific entry for fast/frames/calculate-fixed.html on line LayoutTests/platform/chromium/TestExpectations:2885 overrides line LayoutTests/platform/chromium/TestExpectations:2883. fast/frames/calculate-fixed.html

http://build.chromium.org/p/chromium.webkit/builders/Webkit%20Mac10.6/builds/19523/steps/webkit_lint/logs/stdio

[Vsevolod Vlasov]

(In reply to comment #11)
> (In reply to comment #10)
> > webkit_lint is still red on chromium bots.
> > 
> > http://build.chromium.org/p/chromium.webkit/waterfall?branch=&builder=Webkit+Win+Builder&builder=Webkit+Win&builder=Webkit+Vista&builder=Webkit+Win7&builder=Webkit+Mac+Builder&builder=Webkit+Mac10.5&builder=Webkit+Mac10.6&builder=Webkit+Mac+Builder+%28CG%29&builder=Webkit+Mac10.5+%28CG%29&builder=Webkit+Mac10.6+%28CG%29&builder=Webkit+Mac10.7&builder=Webkit+Linux&builder=Webkit+Linux+32&reload=none
> 
> IMO the actual failure is unrelated to this bug. Looks to me it is failing because of this:
> 
> LayoutTests/platform/chromium/TestExpectations:2885 More specific entry for fast/frames/calculate-fixed.html on line LayoutTests/platform/chromium/TestExpectations:2885 overrides line LayoutTests/platform/chromium/TestExpectations:2883. fast/frames/calculate-fixed.html
> 
> http://build.chromium.org/p/chromium.webkit/builders/Webkit%20Mac10.6/builds/19523/steps/webkit_lint/logs/stdio
That's correct. Sorry for the noise.