Bug 91357

Summary: [TestNetscapePlugin][X11] Additional key up event handler routine is required
Product: WebKit Reporter: KwangYong Choi <ky0.choi>
Component: Plug-insAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, eric, gyuyoung.kim, kbalazs, ky0.choi, lucas.de.marchi, marc.ordinasillopis, rakuco, rniwa, ryuan.choi, vestbo, webkit.review.bot, wez
Priority: P2 Keywords: LayoutTestFailure
Version: 528+ (Nightly build)   
Hardware: Other   
OS: Linux   
Attachments:
Description Flags
Patch
eric: review+, eric: commit-queue-
Patch none

KwangYong Choi
Reported 2012-07-15 22:10:48 PDT
Fixed key up event handler routine to pass http/tests/plugins/plugin-document-has-focus.html on X11 architecture. The test can not be done without this patch. All other ports implemented it already.
Attachments
Patch (1.63 KB, patch)
2012-07-17 03:07 PDT, KwangYong Choi 		eric: review+
eric: commit-queue-
DetailsFormatted DiffDiff
Patch (1.61 KB, patch)
2012-08-13 01:02 PDT, KwangYong Choi 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
KwangYong Choi
Comment 1 2012-07-17 03:07:38 PDT
Created attachment 152723 [details] Patch
Eric Seidel (no email)
Comment 2 2012-08-12 03:26:44 PDT
Comment on attachment 152723 [details] Patch Crazy. This needs to be testRunner now iirc. layoutTestController is dead.
KwangYong Choi
Comment 3 2012-08-13 01:02:45 PDT
Created attachment 157936 [details] Patch Applied the changes. Don't expose window.layoutTestController since all layout tests use window.testRunner instead of window.layoutTestController as of r124685.
WebKit Review Bot
Comment 4 2012-08-13 02:29:45 PDT
Comment on attachment 157936 [details] Patch Clearing flags on attachment: 157936 Committed r125401: <http://trac.webkit.org/changeset/125401>
WebKit Review Bot
Comment 5 2012-08-13 02:29:52 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.