Bug 91357 - [TestNetscapePlugin][X11] Additional key up event handler routine is required
Summary: [TestNetscapePlugin][X11] Additional key up event handler routine is required
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Plug-ins (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other Linux
: P2 Normal
Assignee: Nobody
URL:
Keywords: LayoutTestFailure
Depends on:
Blocks:
 
Reported: 2012-07-15 22:10 PDT by KwangYong Choi
Modified: 2012-08-13 02:29 PDT (History)
13 users (show)

See Also:

Attachments
Patch (1.63 KB, patch)
2012-07-17 03:07 PDT, KwangYong Choi 		eric: review+
eric: commit-queue-
Details | Formatted Diff | Diff
Patch (1.61 KB, patch)
2012-08-13 01:02 PDT, KwangYong Choi 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description KwangYong Choi 2012-07-15 22:10:48 PDT 
Fixed key up event handler routine to pass http/tests/plugins/plugin-document-has-focus.html on X11 architecture. The test can not be done without this patch. All other ports implemented it already.
Comment 1 KwangYong Choi 2012-07-17 03:07:38 PDT 
Created attachment 152723 [details]
Patch
Comment 2 Eric Seidel (no email) 2012-08-12 03:26:44 PDT 
Comment on attachment 152723 [details]
Patch

Crazy.  This needs to be testRunner now iirc.  layoutTestController is dead.
Comment 3 KwangYong Choi 2012-08-13 01:02:45 PDT 
Created attachment 157936 [details]
Patch

Applied the changes.

Don't expose window.layoutTestController since all layout tests use window.testRunner instead of window.layoutTestController as of r124685.
Comment 4 WebKit Review Bot 2012-08-13 02:29:45 PDT 
Comment on attachment 157936 [details]
Patch

Clearing flags on attachment: 157936

Committed r125401: <http://trac.webkit.org/changeset/125401>
Comment 5 WebKit Review Bot 2012-08-13 02:29:52 PDT 
All reviewed patches have been landed.  Closing bug.