Bug 91321

Summary:

REGRESSION(r122665): Broke Mac builds (Requested by rniwa on #webkit).

Product:

WebKit

Reporter:

WebKit Review Bot <webkit.review.bot>

Component:

New Bugs

Assignee:

WebKit Review Bot <webkit.review.bot>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

benjamin, joepeck, rniwa

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

Bug Blocks:

91302

Attachments:

Description	Flags
ROLLOUT of r122665	none

Description WebKit Review Bot 2012-07-14 03:48:56 PDT

http://trac.webkit.org/changeset/122665 broke the build:
Broke Mac builds (Requested by rniwa on #webkit).

This is an automatic bug report generated by the sheriff-bot. If this bug
report was created because of a flaky test, please file a bug for the flaky
test (if we don't already have one on file) and dup this bug against that bug
so that we can track how often these flaky tests case pain.

"Only you can prevent forest fires." -- Smokey the Bear

Comment 1 WebKit Review Bot 2012-07-14 03:49:39 PDT

Created attachment 152419 [details]
ROLLOUT of r122665

Any committer can land this patch automatically by marking it commit-queue+.  The commit-queue will build and test the patch before landing to ensure that the rollout will be successful.  This process takes approximately 15 minutes.

If you would like to land the rollout faster, you can use the following command:

  webkit-patch land-attachment ATTACHMENT_ID

where ATTACHMENT_ID is the ID of this attachment.

Comment 2 Ryosuke Niwa 2012-07-14 03:53:58 PDT

Comment on attachment 152419 [details]
ROLLOUT of r122665

Clearing flags on attachment: 152419

Committed r122667: <http://trac.webkit.org/changeset/122667>

Comment 3 Ryosuke Niwa 2012-07-14 03:54:03 PDT

All reviewed patches have been landed.  Closing bug.

Comment 4 Mark Rowe (bdash) 2012-07-14 14:37:23 PDT

This is exactly the situation where the build should have been fixed rather than rolling the patch out. The fix is so trivial (either forward-declare _postCacheModelChangedNotification or move its definition to before the place it is used) and the build failure is specific to older versions of Xcode.  Rolling out patches with trivial fixes like this seems completely unnecessary.

Comment 5 Ryosuke Niwa 2012-07-14 14:40:36 PDT

(In reply to comment #4)
> This is exactly the situation where the build should have been fixed rather than rolling the patch out. The fix is so trivial (either forward-declare _postCacheModelChangedNotification or move its definition to before the place it is used) and the build failure is specific to older versions of Xcode.  Rolling out patches with trivial fixes like this seems completely unnecessary.

I would have done that if I had known the solution. But I didn't know, and the patch author or anyone else familiar with Obj-C wasn't present at the time. I even waited for half an hour but it was blocking my work so I had to roll it out.

Comment 6 Ryosuke Niwa 2012-07-14 14:41:40 PDT

On a somewhat related note, your r122671 broke mac debug builds:
http://build.webkit.org/builders/Apple%20SnowLeopard%20Debug%20%28Build%29/builds/1433/steps/compile-webkit/logs/stdio