| Summary: | Remove an always-failing table-wrapping check in RenderObject::addChild | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Julien Chaffraix <jchaffraix> | ||||
| Component: | Tables | Assignee: | Julien Chaffraix <jchaffraix> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | darin, eric, webkit.review.bot | ||||
| Priority: | P2 | ||||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | All | ||||||
| OS: | All | ||||||
| Attachments: |
|
||||||
Created attachment 152342 [details]
Proposed removal 1.
Comment on attachment 152342 [details]
Proposed removal 1.
LGTM.
Comment on attachment 152342 [details] Proposed removal 1. Clearing flags on attachment: 152342 Committed r122642: <http://trac.webkit.org/changeset/122642> All reviewed patches have been landed. Closing bug. |
The table wrapping checks in RenderObject::addChild ends with the following snippet: else if (newChild->isTableCell()) { needsTable = !isTableRow(); // I'm not 100% sure this is the best way to fix this, but without this // change we recurse infinitely when trying to render the CSS2 test page: // http://www.bath.ac.uk/%7Epy8ieh/internet/eviltests/htmlbodyheadrendering2.html. // See Radar 2925291. if (needsTable && isTableCell() && !children->firstChild() && !newChild->isTableCell()) needsTable = false; } As we only get into the branch if newChild->isTableCell() so the nested check is always false. The inner check was added in r1147 by Darin and was made obsolete by bug 12066 (circa 2005).