Bug 91277

Summary: NodeLists should not invalidate on irreleavnt attribute changes
Product: WebKit Reporter: Ryosuke Niwa <rniwa>
Component: New BugsAssignee: Ryosuke Niwa <rniwa>
Status: RESOLVED FIXED    
Severity: Normal CC: andersca, arko, cmarcelo, kling, koivisto, ojan, sam, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 89919    
Attachments:
Description Flags
Patch ojan: review+

Description Ryosuke Niwa 2012-07-13 14:06:25 PDT
Merge invalidateNodeListsCacheAfterAttributeChanged and invalidateNodeListsCacheAfterChildrenChanged
Comment 1 Ryosuke Niwa 2012-07-13 14:33:29 PDT
Created attachment 152330 [details]
Patch
Comment 2 Ojan Vafai 2012-07-13 15:04:10 PDT
Comment on attachment 152330 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=152330&action=review

> Source/WebCore/dom/ContainerNode.cpp:683
> +    invalidateNodeListCachesInAncestors(0, 0);

Can you create local variables for these 0's so that it's clear what the arguments are?
Comment 3 Ryosuke Niwa 2012-07-13 15:06:44 PDT
Comment on attachment 152330 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=152330&action=review

Thanks for the review!

>> Source/WebCore/dom/ContainerNode.cpp:683
>> +    invalidateNodeListCachesInAncestors(0, 0);
> 
> Can you create local variables for these 0's so that it's clear what the arguments are?

Oh oops, I meant to add default values of 0 so that we can omit those 0s. Will fix before landing it.
Comment 4 Ryosuke Niwa 2012-07-13 15:44:50 PDT
Committed r122637: <http://trac.webkit.org/changeset/122637>
Comment 5 Ryosuke Niwa 2012-07-13 17:44:38 PDT
Removed an erroneous assertion in http://trac.webkit.org/changeset/122649.