| Summary: | [BlackBerry] resetBitmapZoomScale called while zooming preventing pinch zoom | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Jacky Jiang <jkjiang> | ||||
| Component: | WebKit BlackBerry | Assignee: | Jacky Jiang <jkjiang> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | anilsson, manyoso, mifenton, rwlbuis, staikos, tonikitoo, webkit.review.bot, yong.li.webkit | ||||
| Priority: | P2 | ||||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
Created attachment 152268 [details]
Patch
Comment on attachment 152268 [details]
Patch
As I said on IRC , I dislike this solution: we are putting hacks on top of hacks in my opinion.
Lets rethink this for the future.
(In reply to comment #2) > (From update of attachment 152268 [details]) > As I said on IRC , I dislike this solution: we are putting hacks on top of hacks in my opinion. > > Lets rethink this for the future. Sure, thanks! Comment on attachment 152268 [details] Patch Committed, r122589, http://trac.webkit.org/changeset/122589. |
PR175432. Gen Mak 2012-07-10 18:29:10 EDT: Try pinch zooming yahoo.com or wikipedia.com The page stops zooming while trying to pinch. I tracked it down to: void WebView::resetBitmapZoomScale(double scale) { ... setBitmapZooming(false, false); } after this we ignore all bitmap zoom messages. In fact the yahoo page for some reason always calls resetBitmapZoomScale even without touching it. resetBitmapZoom is being called by void BlackBerry::WebKit::WebPagePrivate::zoomToInitialScaleOnLoad()