Bug 91247

Summary: [BlackBerry] resetBitmapZoomScale called while zooming preventing pinch zoom
Product: WebKit Reporter: Jacky Jiang <jkjiang>
Component: WebKit BlackBerryAssignee: Jacky Jiang <jkjiang>
Status: RESOLVED FIXED    
Severity: Normal CC: anilsson, manyoso, mifenton, rwlbuis, staikos, tonikitoo, webkit.review.bot, yong.li.webkit
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch tonikitoo: review+

Jacky Jiang
Reported 2012-07-13 08:15:22 PDT
PR175432. Gen Mak 2012-07-10 18:29:10 EDT: Try pinch zooming yahoo.com or wikipedia.com The page stops zooming while trying to pinch. I tracked it down to: void WebView::resetBitmapZoomScale(double scale) { ... setBitmapZooming(false, false); } after this we ignore all bitmap zoom messages. In fact the yahoo page for some reason always calls resetBitmapZoomScale even without touching it. resetBitmapZoom is being called by void BlackBerry::WebKit::WebPagePrivate::zoomToInitialScaleOnLoad()
Attachments
Patch (7.44 KB, patch)
2012-07-13 08:29 PDT, Jacky Jiang 		tonikitoo: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Jacky Jiang
Comment 1 2012-07-13 08:29:56 PDT
Created attachment 152268 [details] Patch
Antonio Gomes
Comment 2 2012-07-13 08:55:04 PDT
Comment on attachment 152268 [details] Patch As I said on IRC , I dislike this solution: we are putting hacks on top of hacks in my opinion. Lets rethink this for the future.
Jacky Jiang
Comment 3 2012-07-13 08:59:58 PDT
(In reply to comment #2) > (From update of attachment 152268 [details]) > As I said on IRC , I dislike this solution: we are putting hacks on top of hacks in my opinion. > > Lets rethink this for the future. Sure, thanks!
Jacky Jiang
Comment 4 2012-07-13 09:14:00 PDT
Comment on attachment 152268 [details] Patch Committed, r122589, http://trac.webkit.org/changeset/122589.
Note You need to log in before you can comment on or make changes to this bug.