Bug 91239

Summary: Uses gtk-doc tools even when --disable-gtk-doc passed
Product: WebKit Reporter: Ross Burton <ross>
Component: WebKitGTKAssignee: Alberto Garcia <berto>
Status: RESOLVED FIXED    
Severity: Normal CC: cgarcia, commit-queue, gustavo, mrobinson, zan
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: Linux   
Attachments:
Description Flags
Patch
none
Patch mrobinson: review+

Ross Burton
Reported 2012-07-13 07:17:19 PDT
(using webkitgtk 1.8.1) If I pass --disable-gtk-doc to configure, "make install" errors out because it tries to run gtkdoc-rebase. This happens in Tools/GNUmakefile.am, install-data-local, after it's installed the HTML documentation. (our build system doesn't have gtk-doc as it pulls in Attaching a patch to wrap this call in "if ENABLE_GTK_DOC". If you git repo wasn't larger than the internet itself, I'd have sent this as a git patch. (if this gets accepted, much appreciated if the author email is ross.burton@intel.com)
Attachments
Patch (615 bytes, patch)
2012-07-13 07:17 PDT, Ross Burton 		no flags
DetailsFormatted DiffDiff
Patch (968 bytes, patch)
2013-09-13 11:37 PDT, Alberto Garcia 		mrobinson: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Ross Burton
Comment 1 2012-07-13 07:17:58 PDT
Created attachment 152251 [details] Patch
Alberto Garcia
Comment 2 2013-09-13 11:37:04 PDT
Created attachment 211570 [details] Patch Thanks for the patch, I tested it and it works fine. It just needed a changelog, here it is.
Alberto Garcia
Comment 3 2013-09-14 01:37:31 PDT
Committed r155758: <http://trac.webkit.org/changeset/155758>
Note You need to log in before you can comment on or make changes to this bug.