Bug 91232

Summary: [EFL][WK2] Make new public Ewk headers as installable
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: WebKit2Assignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: gustavo, gyuyoung.kim, kenneth, rakuco, rwlbuis, ryuan.choi, tmpsantos, tonikitoo, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 61838    
Attachments:
Description Flags
Patch none

Description Chris Dumez 2012-07-13 06:29:17 PDT
New public Ewk headers have been added but they were not marked as installable. We need to fix this.
Comment 1 Chris Dumez 2012-07-13 06:30:28 PDT
Created attachment 152242 [details]
Patch
Comment 2 Raphael Kubo da Costa (:rakuco) 2012-07-13 08:06:13 PDT
Comment on attachment 152242 [details]
Patch

LGTM. Do you really need to specify the absolute paths in the list, BTW?
Comment 3 Chris Dumez 2012-07-13 08:08:48 PDT
(In reply to comment #2)
> (From update of attachment 152242 [details])
> LGTM. Do you really need to specify the absolute paths in the list, BTW?

no clue, I merely followed the existing style.
Comment 4 Thiago Marcos P. Santos 2012-07-13 08:52:22 PDT
LGTM.
Comment 5 Thiago Marcos P. Santos 2012-07-13 08:55:53 PDT
(In reply to comment #2)
> (From update of attachment 152242 [details])
> LGTM. Do you really need to specify the absolute paths in the list, BTW?

Or you can define a new variable for this path. But since this is the only place using the particular path, IMO it is not necessary. The patch is fine the way it is now.
Comment 6 Raphael Kubo da Costa (:rakuco) 2012-07-13 09:27:06 PDT
(In reply to comment #5)
> (In reply to comment #2)
> > (From update of attachment 152242 [details] [details])
> > LGTM. Do you really need to specify the absolute paths in the list, BTW?
> 
> Or you can define a new variable for this path. But since this is the only place using the particular path, IMO it is not necessary. The patch is fine the way it is now.

What I mean is that it shouldn't be necessary to define an absolute path at all.
Comment 7 WebKit Review Bot 2012-07-13 10:09:14 PDT
Comment on attachment 152242 [details]
Patch

Clearing flags on attachment: 152242

Committed r122597: <http://trac.webkit.org/changeset/122597>
Comment 8 WebKit Review Bot 2012-07-13 10:09:21 PDT
All reviewed patches have been landed.  Closing bug.