Bug 91223

Summary: [GTK] Silence grep stderr in build-webkit when detecting the current arch
Product: WebKit Reporter: Emanuele Aina <emanuele.aina>
Component: WebKitGTKAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, dbates, eric, mrobinson
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Ignore missing GNUmakefile when detecting previour arch in build-wekit
none
Patch
none
Patch none

Emanuele Aina
Reported 2012-07-13 05:25:56 PDT
Created attachment 152226 [details] Ignore missing GNUmakefile when detecting previour arch in build-wekit When run on a clean checkout, `build-webkit' complains that no GNUmakefile exists when trying to detect the previously configured architecture, but in this case there's no previous configuration so the warning is pointless. Ignoring the error message by redirecting grep stderr to /dev/null should be safe, patch attached.
Attachments
Ignore missing GNUmakefile when detecting previour arch in build-wekit (623 bytes, patch)
2012-07-13 05:25 PDT, Emanuele Aina 		no flags
DetailsFormatted DiffDiff
Patch (1.63 KB, patch)
2013-07-12 10:47 PDT, Emanuele Aina 		no flags
DetailsFormatted DiffDiff
Patch (1.63 KB, patch)
2013-07-12 10:59 PDT, Emanuele Aina 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Eric Seidel (no email)
Comment 1 2012-08-12 03:29:14 PDT
Comment on attachment 152226 [details] Ignore missing GNUmakefile when detecting previour arch in build-wekit OK. But this needs a ChangeLog.
Emanuele Aina
Comment 2 2013-07-12 10:47:25 PDT
Created attachment 206554 [details] Patch
Martin Robinson
Comment 3 2013-07-12 10:52:07 PDT
Comment on attachment 206554 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=206554&action=review > Tools/ChangeLog:6 > + Reviewed by Eric Seidel. I think maybe this is a copy and paste error.
Emanuele Aina
Comment 4 2013-07-12 10:59:13 PDT
Created attachment 206556 [details] Patch Use OOPS to automatically generate a proper 'Reviewed by' line in the ChangeLog
Martin Robinson
Comment 5 2013-07-12 11:01:21 PDT
Comment on attachment 206556 [details] Patch Thanks!
Emanuele Aina
Comment 6 2013-07-12 11:03:40 PDT
(In reply to comment #3) > > + Reviewed by Eric Seidel. > I think maybe this is a copy and paste error. Erhm, no, since Eric already said OK to the patch and just mentioned the lack of proper ChangeLog entry I assumed it would have been fine to indicate him as reviewer. But since you taught me about the OOPS magic this seems to be a good candidate to try it out. :D However, thanks for the reviews!
Martin Robinson
Comment 7 2013-07-12 11:05:38 PDT
Ah, sorry. Didn't see that.
WebKit Commit Bot
Comment 8 2013-07-12 11:58:31 PDT
Comment on attachment 206556 [details] Patch Clearing flags on attachment: 206556 Committed r152601: <http://trac.webkit.org/changeset/152601>
WebKit Commit Bot
Comment 9 2013-07-12 11:58:33 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.