Bug 91221

Summary: [CMake] Proper handling of ENABLE_API_TESTS build option
Product: WebKit Reporter: Thiago Marcos P. Santos <tmpsantos>
Component: Tools / TestsAssignee: Thiago Marcos P. Santos <tmpsantos>
Status: RESOLVED FIXED    
Severity: Normal CC: dbates, rakuco, tonikitoo, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 90451, 90973    
Attachments:
Description Flags
Patch none

Thiago Marcos P. Santos
Reported 2012-07-13 04:38:36 PDT
Make it reusable across the ports using CMake. We are about to enable the WTF, WebCore and WebKit 2 API's at Tools/TestWebKitAPI and other ports can get it almost for free.
Attachments
Patch (7.91 KB, patch)
2012-07-13 06:28 PDT, Thiago Marcos P. Santos 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Thiago Marcos P. Santos
Comment 1 2012-07-13 06:28:10 PDT
Created attachment 152240 [details] Patch
Chris Dumez
Comment 2 2012-07-13 07:38:23 PDT
Comment on attachment 152240 [details] Patch LGTM.
Raphael Kubo da Costa (:rakuco)
Comment 3 2012-07-13 08:04:12 PDT
Comment on attachment 152240 [details] Patch I don't see an option to enable API tests in FeatureLists.pm, so the idea is that these features in WebKitFeatures.cmake, OptionsEfl.cmake and the rest should have their values changed manually?
Thiago Marcos P. Santos
Comment 4 2012-07-13 08:11:20 PDT
(In reply to comment #3) > (From update of attachment 152240 [details]) > I don't see an option to enable API tests in FeatureLists.pm, so the idea is that these features in WebKitFeatures.cmake, OptionsEfl.cmake and the rest should have their values changed manually? It doesn't go to FeatureList.pm because it only makes sense for the cmake build system. Not manually, you can disable it by doing: $ Tools/Scripts/build-webkit --efl --cmakearg="-DENABLE_API_TESTS=OFF"
Rob Buis
Comment 5 2012-07-13 08:20:33 PDT
Comment on attachment 152240 [details] Patch Looks good, thanks for doing this work, BlackBerry port also wants to enable this soonish.
WebKit Review Bot
Comment 6 2012-07-13 10:25:29 PDT
Comment on attachment 152240 [details] Patch Clearing flags on attachment: 152240 Committed r122601: <http://trac.webkit.org/changeset/122601>
WebKit Review Bot
Comment 7 2012-07-13 10:25:34 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.