| Summary: | [CMake] Proper handling of ENABLE_API_TESTS build option | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Thiago Marcos P. Santos <tmpsantos> | ||||
| Component: | Tools / Tests | Assignee: | Thiago Marcos P. Santos <tmpsantos> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | dbates, rakuco, tonikitoo, webkit.review.bot | ||||
| Priority: | P2 | ||||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Bug Depends on: | |||||||
| Bug Blocks: | 90451, 90973 | ||||||
| Attachments: |
|
||||||
|
Description
Thiago Marcos P. Santos
2012-07-13 04:38:36 PDT
Created attachment 152240 [details]
Patch
Comment on attachment 152240 [details]
Patch
LGTM.
Comment on attachment 152240 [details]
Patch
I don't see an option to enable API tests in FeatureLists.pm, so the idea is that these features in WebKitFeatures.cmake, OptionsEfl.cmake and the rest should have their values changed manually?
(In reply to comment #3) > (From update of attachment 152240 [details]) > I don't see an option to enable API tests in FeatureLists.pm, so the idea is that these features in WebKitFeatures.cmake, OptionsEfl.cmake and the rest should have their values changed manually? It doesn't go to FeatureList.pm because it only makes sense for the cmake build system. Not manually, you can disable it by doing: $ Tools/Scripts/build-webkit --efl --cmakearg="-DENABLE_API_TESTS=OFF" Comment on attachment 152240 [details]
Patch
Looks good, thanks for doing this work, BlackBerry port also wants to enable this soonish.
Comment on attachment 152240 [details] Patch Clearing flags on attachment: 152240 Committed r122601: <http://trac.webkit.org/changeset/122601> All reviewed patches have been landed. Closing bug. |