Bug 91217

Summary: [CallWith=XXX] arguments should be placed at the head of method arguments
Product: WebKit Reporter: Kentaro Hara <haraken>
Component: WebCore JavaScriptAssignee: Kentaro Hara <haraken>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, dw.im, gyuyoung.kim, japhet, jochen, kinuko, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Kentaro Hara
Reported 2012-07-13 04:21:17 PDT
The EFL build with the ENABLE_FILE_SYSTEM flag caused a build error, because CodeGeneratorJS.pm assumes webkitEntries(ScriptExecutionContext*, HTMLInputElement*) but the actual signature is webkitEntries(HTMLInputElement*, ScriptExecutionContext*) (bug 91185). Per https://trac.webkit.org/wiki/WebKitIDL#CallWith, [CallWith=XXX] arguments should be placed at the head of the arguments. (i.e. the behavior of CodeGeneratorJS.pm is correct.) Thus the correct fix is (1) to change the signature of webkitEntries() and webkitGetAsEntry() so that ScriptExecutionContext* comes first and (2) to modify CodeGeneratorV8.pm to support the order.
Attachments
Patch (8.68 KB, patch)
2012-07-13 04:34 PDT, Kentaro Hara 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Kentaro Hara
Comment 1 2012-07-13 04:34:42 PDT
Created attachment 152217 [details] Patch
WebKit Review Bot
Comment 2 2012-07-13 11:16:05 PDT
Comment on attachment 152217 [details] Patch Clearing flags on attachment: 152217 Committed r122608: <http://trac.webkit.org/changeset/122608>
WebKit Review Bot
Comment 3 2012-07-13 11:16:10 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.