Bug 91217

Summary:

[CallWith=XXX] arguments should be placed at the head of method arguments

Product:

WebKit

Reporter:

Kentaro Hara <haraken>

Component:

WebCore JavaScript

Assignee:

Kentaro Hara <haraken>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

abarth, dw.im, gyuyoung.kim, japhet, jochen, kinuko, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none

Description Kentaro Hara 2012-07-13 04:21:17 PDT

The EFL build with the ENABLE_FILE_SYSTEM flag caused a build error, because CodeGeneratorJS.pm assumes webkitEntries(ScriptExecutionContext*, HTMLInputElement*) but the actual signature is webkitEntries(HTMLInputElement*, ScriptExecutionContext*) (bug 91185).

Per https://trac.webkit.org/wiki/WebKitIDL#CallWith, [CallWith=XXX] arguments should be placed at the head of the arguments. (i.e. the behavior of CodeGeneratorJS.pm is correct.)

Thus the correct fix is (1) to change the signature of webkitEntries() and webkitGetAsEntry() so that ScriptExecutionContext* comes first and (2) to modify CodeGeneratorV8.pm to support the order.

Comment 1 Kentaro Hara 2012-07-13 04:34:42 PDT

Created attachment 152217 [details]
Patch

Comment 2 WebKit Review Bot 2012-07-13 11:16:05 PDT

Comment on attachment 152217 [details]
Patch

Clearing flags on attachment: 152217

Committed r122608: <http://trac.webkit.org/changeset/122608>

Comment 3 WebKit Review Bot 2012-07-13 11:16:10 PDT

All reviewed patches have been landed.  Closing bug.