Bug 91203

Summary: Make CSS box model background, border and mask be decoded by parallel image decoders.
Product: WebKit Reporter: Dongseong Hwang <dongseong.hwang>
Component: ImagesAssignee: Nobody <webkit-unassigned>
Status: UNCONFIRMED ---    
Severity: Normal CC: dglazkov, eric, gram, gustavo, peter+ews, philn, skyul, webkit.review.bot, xan.lopez
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 90935    
Bug Blocks: 90375    
Attachments:
Description Flags
Patch eric: review-, dongseong.hwang: commit-queue-

Description Dongseong Hwang 2012-07-13 01:40:12 PDT
There are two changes.

1. Make RenderBoxModelObject use RetainedModeBitmapImage if the image is
an instance of BitmapImage.

2. Originally, the renderer checked if a CSS image was loaded in order to
render the entire image. With parallel image decoders, loading done does not always
mean the whole image can be rendered. Now if the given image is a BitmapImage,
we need to check if decoding is completed in addition to loading done.
Comment 1 Dongseong Hwang 2012-07-13 01:45:09 PDT
Created attachment 152189 [details]
Patch
Comment 2 Build Bot 2012-07-13 02:08:04 PDT
Comment on attachment 152189 [details]
Patch

Attachment 152189 [details] did not pass mac-ews (mac):
Output: http://queues.webkit.org/results/13240026
Comment 3 Build Bot 2012-07-13 02:29:25 PDT
Comment on attachment 152189 [details]
Patch

Attachment 152189 [details] did not pass win-ews (win):
Output: http://queues.webkit.org/results/13239025
Comment 4 WebKit Review Bot 2012-07-13 02:49:29 PDT
Comment on attachment 152189 [details]
Patch

Attachment 152189 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/13236053
Comment 5 Early Warning System Bot 2012-07-13 03:12:27 PDT
Comment on attachment 152189 [details]
Patch

Attachment 152189 [details] did not pass qt-ews (qt):
Output: http://queues.webkit.org/results/13207985
Comment 6 Early Warning System Bot 2012-07-13 03:17:41 PDT
Comment on attachment 152189 [details]
Patch

Attachment 152189 [details] did not pass qt-wk2-ews (qt):
Output: http://queues.webkit.org/results/13241042
Comment 7 Gyuyoung Kim 2012-07-13 03:33:23 PDT
Comment on attachment 152189 [details]
Patch

Attachment 152189 [details] did not pass efl-ews (efl):
Output: http://queues.webkit.org/results/13239032
Comment 8 Kwang Yul Seo 2012-07-13 04:19:55 PDT
This patch doesn't build until Bug 90935 is resolved. Can't we disable build bots until dependencies are resolved?
Comment 9 Peter Beverloo (cr-android ews) 2012-08-09 21:05:28 PDT
Comment on attachment 152189 [details]
Patch

Attachment 152189 [details] did not pass cr-android-ews (chromium-android):
Output: http://queues.webkit.org/results/13475104
Comment 10 Eric Seidel (no email) 2012-08-12 03:30:13 PDT
Comment on attachment 152189 [details]
Patch

This breaks all the builds. :(
Comment 11 Kwang Yul Seo 2012-08-13 05:03:49 PDT
(In reply to comment #10)
> (From update of attachment 152189 [details])
> This breaks all the builds. :(

Eric, this bug has a dependency on Bug 90935 which has not yet been committed. Can't I disable build bots?