Bug 91203

Summary:

Make CSS box model background, border and mask be decoded by parallel image decoders.

Product:

WebKit

Reporter:

Dongseong Hwang <dongseong.hwang>

Component:

Images

Assignee:

Nobody <webkit-unassigned>

Status:

UNCONFIRMED

Severity:

Normal

CC:

dglazkov, eric, gram, gustavo, peter+ews, philn, skyul, webkit.review.bot, xan.lopez

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

90935

Bug Blocks:

90375

Attachments:

Description	Flags
Patch	eric: review-, dongseong.hwang: commit-queue-

Dongseong Hwang

Reported 2012-07-13 01:40:12 PDT

There are two changes. 1. Make RenderBoxModelObject use RetainedModeBitmapImage if the image is an instance of BitmapImage. 2. Originally, the renderer checked if a CSS image was loaded in order to render the entire image. With parallel image decoders, loading done does not always mean the whole image can be rendered. Now if the given image is a BitmapImage, we need to check if decoding is completed in addition to loading done.

Attachments
Patch (19.49 KB, patch) 2012-07-13 01:45 PDT, Dongseong Hwang	eric: review- dongseong.hwang: commit-queue-	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Dongseong Hwang

Comment 1 2012-07-13 01:45:09 PDT

Created attachment 152189 [details] Patch

Build Bot

Comment 2 2012-07-13 02:08:04 PDT

Comment on attachment 152189 [details] Patch Attachment 152189 [details] did not pass mac-ews (mac): Output: http://queues.webkit.org/results/13240026

Build Bot

Comment 3 2012-07-13 02:29:25 PDT

Comment on attachment 152189 [details] Patch Attachment 152189 [details] did not pass win-ews (win): Output: http://queues.webkit.org/results/13239025

WebKit Review Bot

Comment 4 2012-07-13 02:49:29 PDT

Comment on attachment 152189 [details] Patch Attachment 152189 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/13236053

Early Warning System Bot

Comment 5 2012-07-13 03:12:27 PDT

Comment on attachment 152189 [details] Patch Attachment 152189 [details] did not pass qt-ews (qt): Output: http://queues.webkit.org/results/13207985

Early Warning System Bot

Comment 6 2012-07-13 03:17:41 PDT

Comment on attachment 152189 [details] Patch Attachment 152189 [details] did not pass qt-wk2-ews (qt): Output: http://queues.webkit.org/results/13241042

Gyuyoung Kim

Comment 7 2012-07-13 03:33:23 PDT

Comment on attachment 152189 [details] Patch Attachment 152189 [details] did not pass efl-ews (efl): Output: http://queues.webkit.org/results/13239032

Kwang Yul Seo

Comment 8 2012-07-13 04:19:55 PDT

This patch doesn't build until Bug 90935 is resolved. Can't we disable build bots until dependencies are resolved?

Peter Beverloo (cr-android ews)

Comment 9 2012-08-09 21:05:28 PDT

Comment on attachment 152189 [details] Patch Attachment 152189 [details] did not pass cr-android-ews (chromium-android): Output: http://queues.webkit.org/results/13475104

Eric Seidel (no email)

Comment 10 2012-08-12 03:30:13 PDT

Comment on attachment 152189 [details] Patch This breaks all the builds. :(

Kwang Yul Seo

Comment 11 2012-08-13 05:03:49 PDT

(In reply to comment #10) > (From update of attachment 152189 [details]) > This breaks all the builds. :( Eric, this bug has a dependency on Bug 90935 which has not yet been committed. Can't I disable build bots?

Note You need to log in before you can comment on or make changes to this bug.