Bug 91198

Summary: CodeGeneratorJS.pm : SetterExpression should use 'push' rather than 'unshift'
Product: WebKit Reporter: Dongwoo Joshua Im (dwim) <dw.im>
Component: WebKit Misc.Assignee: Nobody <webkit-unassigned>
Status: RESOLVED INVALID    
Severity: Normal CC: abarth, haraken, japhet, jochen, tmpsantos, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: Linux   
Attachments:
Description Flags
Patch none

Dongwoo Joshua Im (dwim)
Reported 2012-07-13 00:28:36 PDT
Regarding CodeGeneratorV8.pm, 'SetterExpression' should 'push' to make arguments, rather than 'unshift'. I'll upload the patch soon.
Attachments
Patch (1.62 KB, patch)
2012-07-13 00:40 PDT, Dongwoo Joshua Im (dwim) 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Dongwoo Joshua Im (dwim)
Comment 1 2012-07-13 00:40:57 PDT
Created attachment 152171 [details] Patch This is also needed to fix.
Kentaro Hara
Comment 2 2012-07-13 00:48:08 PDT
Comment on attachment 152171 [details] Patch Sounds reasonable. (Although I don't know there is a use case affected by this change.)
WebKit Review Bot
Comment 3 2012-07-13 02:05:37 PDT
Comment on attachment 152171 [details] Patch Clearing flags on attachment: 152171 Committed r122553: <http://trac.webkit.org/changeset/122553>
WebKit Review Bot
Comment 4 2012-07-13 02:05:48 PDT
All reviewed patches have been landed. Closing bug.
Thiago Marcos P. Santos
Comment 5 2012-07-13 03:28:17 PDT
Bindings generation tests are failing after this patch: http://build.webkit.org/builders/EFL%20Linux%2064-bit%20Debug/builds/2751
Kentaro Hara
Comment 6 2012-07-13 04:04:29 PDT
This was a wrong fix. Rolled out at r122553.
Note You need to log in before you can comment on or make changes to this bug.