Bug 91194

Summary: enable TestWebKitAPI/webkit_unit_tests apk on x86 android platform by adding abi support
Product: WebKit Reporter: Wei James (wistoch) <james.wei>
Component: New BugsAssignee: Wei James (wistoch) <james.wei>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, peter, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Android   
OS: Android   
Bug Depends on:    
Bug Blocks: 88658    
Attachments:
Description Flags
Patch none

Wei James (wistoch)
Reported 2012-07-12 23:47:30 PDT
enable TestWebKitAPI/webkit_unit_tests apk on x86 android platform by adding abi support
Attachments
Patch (2.75 KB, patch)
2012-07-12 23:48 PDT, Wei James (wistoch) 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Wei James (wistoch)
Comment 1 2012-07-12 23:48:29 PDT
Created attachment 152162 [details] Patch
Wei James (wistoch)
Comment 2 2012-07-13 00:54:08 PDT
by default, the .so will be put into armeabi folder. adding --app-abi option will put the native binary to correct place.
Peter Beverloo
Comment 3 2012-07-13 06:13:12 PDT
LGTM, thank you for doing this!
Adam Barth
Comment 4 2012-07-13 10:18:23 PDT
Comment on attachment 152162 [details] Patch If Peter says this patch is good, that's enough for me. :)
WebKit Review Bot
Comment 5 2012-07-13 10:57:58 PDT
Comment on attachment 152162 [details] Patch Clearing flags on attachment: 152162 Committed r122606: <http://trac.webkit.org/changeset/122606>
WebKit Review Bot
Comment 6 2012-07-13 10:58:03 PDT
All reviewed patches have been landed. Closing bug.
Wei James (wistoch)
Comment 7 2012-07-13 20:40:57 PDT
peter, abarth, thanks. James
Note You need to log in before you can comment on or make changes to this bug.