Bug 91170

Summary:

webkitpy: make worker.start() and worker.stop() optional in the messagepool

Product:

WebKit

Reporter:

Dirk Pranke <dpranke>

Component:

New Bugs

Assignee:

Dirk Pranke <dpranke>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

abarth, ojan, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	ojan: review+

Dirk Pranke

Reported 2012-07-12 17:32:21 PDT

webkitpy: make worker.start() and worker.stop() optional in the messagepool

Attachments
Patch (2.32 KB, patch) 2012-07-12 17:37 PDT, Dirk Pranke	ojan: review+	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Dirk Pranke

Comment 1 2012-07-12 17:37:55 PDT

Ojan Vafai

Comment 2 2012-07-13 09:31:24 PDT

Comment on attachment 152109 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=152109&action=review > Tools/Scripts/webkitpy/common/message_pool.py:212 > + if hasattr(self._worker, 'stop'): Does "if self.worker.stop" throw an undefined error or something?

Dirk Pranke

Comment 3 2012-07-13 09:58:46 PDT

(In reply to comment #2) > (From update of attachment 152109 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=152109&action=review > > > Tools/Scripts/webkitpy/common/message_pool.py:212 > > + if hasattr(self._worker, 'stop'): > > Does "if self.worker.stop" throw an undefined error or something? Yes.

Dirk Pranke

Comment 4 2012-07-13 12:11:42 PDT

Note You need to log in before you can comment on or make changes to this bug.