Bug 91156

Summary: Fix QtWebKit build with OpenGLES after GC3D/E3D refactor
Product: WebKit Reporter: Lauro Moura Maranhao Neto <lauro.neto>
Component: WebCore Misc.Assignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: jnetterfield, noam, rwlbuis, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch for landing none

Description Lauro Moura Maranhao Neto 2012-07-12 15:30:25 PDT
After r122250 the Qt port fails to build with several errors. A partial fix was landed in 91030.

Already working on this.
Comment 1 Lauro Moura Maranhao Neto 2012-07-12 16:18:44 PDT
Created attachment 152089 [details]
Patch
Comment 2 Noam Rosenthal 2012-07-12 16:47:50 PDT
Comment on attachment 152089 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=152089&action=review

This looks good to me, but before landing I want to understand why reshapeFBOs was removed in the first place.

> Source/WebCore/platform/graphics/opengl/Extensions3DOpenGLES.cpp:73
> +    // unsupported

Call notImplemented() instead of a comment.
Comment 3 Lauro Moura Maranhao Neto 2012-07-12 17:37:22 PDT
Created attachment 152108 [details]
Patch for landing
Comment 4 Joshua Netterfield 2012-07-13 07:03:31 PDT
I thought that reshapeFBOs was BlackBerry-specific because in our downstream repo it was blocked by '#if PLATFORM(BLACKBERRY)'. Sorry about that.
Comment 5 WebKit Review Bot 2012-07-13 08:52:10 PDT
Comment on attachment 152108 [details]
Patch for landing

Clearing flags on attachment: 152108

Committed r122586: <http://trac.webkit.org/changeset/122586>
Comment 6 WebKit Review Bot 2012-07-13 08:52:16 PDT
All reviewed patches have been landed.  Closing bug.