Summary: | Fix QtWebKit build with OpenGLES after GC3D/E3D refactor | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Lauro Moura Maranhao Neto <lauro.neto> | ||||||
Component: | WebCore Misc. | Assignee: | Nobody <webkit-unassigned> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | jnetterfield, noam, rwlbuis, webkit.review.bot | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Attachments: |
|
Description
Lauro Moura Maranhao Neto
2012-07-12 15:30:25 PDT
Created attachment 152089 [details]
Patch
Comment on attachment 152089 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=152089&action=review This looks good to me, but before landing I want to understand why reshapeFBOs was removed in the first place. > Source/WebCore/platform/graphics/opengl/Extensions3DOpenGLES.cpp:73 > + // unsupported Call notImplemented() instead of a comment. Created attachment 152108 [details]
Patch for landing
I thought that reshapeFBOs was BlackBerry-specific because in our downstream repo it was blocked by '#if PLATFORM(BLACKBERRY)'. Sorry about that. Comment on attachment 152108 [details] Patch for landing Clearing flags on attachment: 152108 Committed r122586: <http://trac.webkit.org/changeset/122586> All reviewed patches have been landed. Closing bug. |