Bug 91143

Summary:

[BlackBerry] Upstream WebGL Code

Product:

WebKit

Reporter:

Joshua Netterfield <jnetterfield>

Component:

WebKit BlackBerry

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

gyuyoung.kim, mifenton, rakuco, tonikitoo, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch	none
Patch	none
Patch	none
Patch	none

Joshua Netterfield

Reported 2012-07-12 13:27:48 PDT

Upstream WebGL code for BlackBerry port

Attachments
Patch (39.04 KB, patch) 2012-07-13 15:12 PDT, Joshua Netterfield	no flags	Details Formatted Diff Diff
Patch (32.55 KB, patch) 2012-07-16 08:20 PDT, Joshua Netterfield	no flags	Details Formatted Diff Diff
Patch (31.99 KB, patch) 2012-07-16 08:47 PDT, Joshua Netterfield	no flags	Details Formatted Diff Diff
Patch (32.08 KB, patch) 2012-07-16 09:53 PDT, Joshua Netterfield	no flags	Details Formatted Diff Diff
Patch (30.29 KB, patch) 2012-07-16 12:11 PDT, Joshua Netterfield	no flags	Details Formatted Diff Diff
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.

Joshua Netterfield

Comment 1 2012-07-13 15:12:03 PDT

Created attachment 152350 [details] Patch

Joshua Netterfield

Comment 2 2012-07-13 15:28:27 PDT

Will revert changes to readPixels Monday.

Joshua Netterfield

Comment 3 2012-07-16 08:20:28 PDT

Created attachment 152538 [details] Patch

Rob Buis

Comment 4 2012-07-16 08:39:49 PDT

Comment on attachment 152538 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=152538&action=review Still some things to cleanup. > Source/WebCore/ChangeLog:3 > + This patch includes BlackBerry-specific fixes for anti-aliasing, logging, and shader compilation. This line should go below the Reviewed by line. > Source/WebCore/ChangeLog:23 > + * platform/graphics/opengl/Extensions3DOpenGL.h: Remove unnecessary whitespace. Remove unnecessary whitespace. <- there is unnecessary whitespace in that sentence. > Source/WebKit/ChangeLog:3 > + This patch includes BlackBerry-specific fixes for anti-aliasing, logging, and shader compilation. This line should go below the Reviewed by line. > Source/WebCore/platform/graphics/opengl/Extensions3DOpenGLCommon.cpp:142 > +#endif Better add some whitespace in some of these lines. > Source/WebCore/platform/graphics/opengl/GraphicsContext3DOpenGLES.cpp:53 > + // Currently only format=RGBA, type=UNSIGNED_BYTE is supported by the specification: http://www.khronos.org/reg Huh? gives 404

Joshua Netterfield

Comment 5 2012-07-16 08:47:19 PDT

Created attachment 152543 [details] Patch

Joshua Netterfield

Comment 6 2012-07-16 09:53:04 PDT

Created attachment 152554 [details] Patch

Joshua Netterfield

Comment 7 2012-07-16 12:11:05 PDT

Created attachment 152582 [details] Patch

Rob Buis

Comment 8 2012-07-16 12:52:59 PDT

Comment on attachment 152582 [details] Patch Ok.