Bug 91140

Summary:

[Qt] [Part 5] platform/qt/css1 tests needs update after rebaseline and new testfonts

Product:

WebKit

Reporter:

Luciano Wolf <luciano.wolf>

Component:

Tools / Tests

Assignee:

Luciano Wolf <luciano.wolf>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

91134

Bug Blocks:

85203, 91142

Attachments:

Description	Flags
Batch of reviewed expected results - css1 - part5	none
Patch for landing	none
Patch for landing	none

Luciano Wolf

Reported 2012-07-12 13:03:54 PDT

After the rebaseline proposed by Bug 85203 - [Qt] DumpRenderTree does not use 'monospace' font when directed, css1 tests directory needs to be updated. The new expected results came from buildbot's output: https://lists.webkit.org/pipermail/webkit-qt/2012-July/002967.html [Part 5] includes pseudo and units directories under css1.

Attachments
Batch of reviewed expected results - css1 - part5 (1.66 MB, patch) 2012-07-12 13:13 PDT, Luciano Wolf	no flags	Details Formatted Diff Diff
Patch for landing (1.66 MB, patch) 2012-07-19 09:08 PDT, Luciano Wolf	no flags	Details Formatted Diff Diff
Patch for landing (1.66 MB, patch) 2012-07-19 13:12 PDT, Luciano Wolf	no flags	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

Luciano Wolf

Comment 1 2012-07-12 13:13:05 PDT

Created attachment 152039 [details] Batch of reviewed expected results - css1 - part5

Simon Hausmann

Comment 2 2012-07-19 07:22:13 PDT

Comment on attachment 152039 [details] Batch of reviewed expected results - css1 - part5 rs=me

Luciano Wolf

Comment 3 2012-07-19 09:08:33 PDT

Created attachment 153274 [details] Patch for landing

WebKit Review Bot

Comment 4 2012-07-19 09:32:49 PDT

Comment on attachment 153274 [details] Patch for landing Rejecting attachment 153274 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: sts/platform/qt/css1/pseudo/pseudo_elements_in_selectors-expected.txt patching file LayoutTests/platform/qt/css1/units/color_units-expected.txt patching file LayoutTests/platform/qt/css1/units/length_units-expected.txt patching file LayoutTests/platform/qt/css1/units/percentage_units-expected.txt patching file LayoutTests/platform/qt/css1/units/urls-expected.txt Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--force']" exit_code: 1 cwd: /mnt/git/webkit-commit-queue/ Full output: http://queues.webkit.org/results/13284911

Luciano Wolf

Comment 5 2012-07-19 13:12:23 PDT

Created attachment 153331 [details] Patch for landing

WebKit Review Bot

Comment 6 2012-07-19 13:56:23 PDT

Comment on attachment 153331 [details] Patch for landing Clearing flags on attachment: 153331 Committed r123148: <http://trac.webkit.org/changeset/123148>

WebKit Review Bot

Comment 7 2012-07-19 13:56:28 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.