Bug 91135

Summary: DFG property access stubs should use structure transition watchpoints
Product: WebKit Reporter: Filip Pizlo <fpizlo>
Component: JavaScriptCoreAssignee: Filip Pizlo <fpizlo>
Status: RESOLVED FIXED    
Severity: Normal CC: gustavo, rakuco, webkit.review.bot, xan.lopez
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
work in progress
gyuyoung.kim: commit-queue-
the patch ggaren: review+

Filip Pizlo
Reported 2012-07-12 12:47:40 PDT
Patch forthcoming.
Attachments
work in progress (25.12 KB, patch)
2012-07-12 12:52 PDT, Filip Pizlo 		gyuyoung.kim: commit-queue-
DetailsFormatted DiffDiff
the patch (27.59 KB, patch)
2012-07-12 15:08 PDT, Filip Pizlo 		ggaren: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Filip Pizlo
Comment 1 2012-07-12 12:52:43 PDT
Created attachment 152030 [details] work in progress
WebKit Review Bot
Comment 2 2012-07-12 14:57:36 PDT
Attachment 152030 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/ChangeLog', u'Source..." exit_code: 1 Source/JavaScriptCore/bytecode/StructureStubClearingWatchpoint.h:93: The parameter name "codeBlock" adds no information, so it should be removed. [readability/parameter_name] [5] Source/JavaScriptCore/bytecode/StructureStubClearingWatchpoint.h:94: The parameter name "stubInfo" adds no information, so it should be removed. [readability/parameter_name] [5] Total errors found: 2 in 9 files If any of these errors are false positives, please file a bug against check-webkit-style.
Gyuyoung Kim
Comment 3 2012-07-12 15:01:58 PDT
Comment on attachment 152030 [details] work in progress Attachment 152030 [details] did not pass efl-ews (efl): Output: http://queues.webkit.org/results/13199867
Gustavo Noronha (kov)
Comment 4 2012-07-12 15:03:52 PDT
Comment on attachment 152030 [details] work in progress Attachment 152030 [details] did not pass gtk-ews (gtk): Output: http://queues.webkit.org/results/13180971
Build Bot
Comment 5 2012-07-12 15:06:12 PDT
Comment on attachment 152030 [details] work in progress Attachment 152030 [details] did not pass win-ews (win): Output: http://queues.webkit.org/results/13182960
Filip Pizlo
Comment 6 2012-07-12 15:08:56 PDT
Created attachment 152073 [details] the patch Actually added build foo this time.
Geoffrey Garen
Comment 7 2012-07-12 15:32:55 PDT
Comment on attachment 152073 [details] the patch r=me
Filip Pizlo
Comment 8 2012-07-12 23:41:45 PDT
Landed in http://trac.webkit.org/changeset/122544
Note You need to log in before you can comment on or make changes to this bug.