Bug 91135 - DFG property access stubs should use structure transition watchpoints
Summary: DFG property access stubs should use structure transition watchpoints
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Filip Pizlo
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-07-12 12:47 PDT by Filip Pizlo
Modified: 2012-07-12 23:41 PDT (History)
4 users (show)

See Also:

Attachments
work in progress (25.12 KB, patch)
2012-07-12 12:52 PDT, Filip Pizlo 		gyuyoung.kim: commit-queue-
Details | Formatted Diff | Diff
the patch (27.59 KB, patch)
2012-07-12 15:08 PDT, Filip Pizlo 		ggaren: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Filip Pizlo 2012-07-12 12:47:40 PDT 
Patch forthcoming.
Comment 1 Filip Pizlo 2012-07-12 12:52:43 PDT 
Created attachment 152030 [details]
work in progress
Comment 2 WebKit Review Bot 2012-07-12 14:57:36 PDT 
Attachment 152030 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/ChangeLog', u'Source..." exit_code: 1
Source/JavaScriptCore/bytecode/StructureStubClearingWatchpoint.h:93:  The parameter name "codeBlock" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/JavaScriptCore/bytecode/StructureStubClearingWatchpoint.h:94:  The parameter name "stubInfo" adds no information, so it should be removed.  [readability/parameter_name] [5]
Total errors found: 2 in 9 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Gyuyoung Kim 2012-07-12 15:01:58 PDT 
Comment on attachment 152030 [details]
work in progress

Attachment 152030 [details] did not pass efl-ews (efl):
Output: http://queues.webkit.org/results/13199867
Comment 4 Gustavo Noronha (kov) 2012-07-12 15:03:52 PDT 
Comment on attachment 152030 [details]
work in progress

Attachment 152030 [details] did not pass gtk-ews (gtk):
Output: http://queues.webkit.org/results/13180971
Comment 5 Build Bot 2012-07-12 15:06:12 PDT 
Comment on attachment 152030 [details]
work in progress

Attachment 152030 [details] did not pass win-ews (win):
Output: http://queues.webkit.org/results/13182960
Comment 6 Filip Pizlo 2012-07-12 15:08:56 PDT 
Created attachment 152073 [details]
the patch

Actually added build foo this time.
Comment 7 Geoffrey Garen 2012-07-12 15:32:55 PDT 
Comment on attachment 152073 [details]
the patch

r=me
Comment 8 Filip Pizlo 2012-07-12 23:41:45 PDT 
Landed in http://trac.webkit.org/changeset/122544