Bug 91129 – NRWT doesn't print exceptions

• Component: Tools / Tests
• Status: RESOLVED FIXED

[Xianzhu Wang]

On exception occurred in the main program, NRWT just exits with status EXCEPTIONAL_EXIT_STATUS but doesn't print the exception, making it difficult to debug the issue.

To test:
1. Create a syntax error in port/webkit.py
2. Run NRWT

Actual result:
NRWT just exists without any error message

Expected result:
NRWT should print the error.

In addition, if some worker raises some exception, NRWT just print the stack trace without the type and message of the exception.

[Dirk Pranke]

Created attachment 152129 [details]
Patch

[WebKit Review Bot]

Attachment 152129 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Tools/ChangeLog', u'Tools/Scripts/webkitpy..." exit_code: 1
Tools/Scripts/webkitpy/common/message_pool.py:277:  deprecated form of raising exception  [pep8/W602] [5]
Total errors found: 1 in 4 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Dirk Pranke]

(In reply to comment #2)
> Attachment 152129 [details] did not pass style-queue:
> 
> Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Tools/ChangeLog', u'Tools/Scripts/webkitpy..." exit_code: 1
> Tools/Scripts/webkitpy/common/message_pool.py:277:  deprecated form of raising exception  [pep8/W602] [5]
> Total errors found: 1 in 4 files
> 
> 
> If any of these errors are false positives, please file a bug against check-webkit-style.

This style error is unavoidable and can be ignored.

[Ojan Vafai]

Comment on attachment 152129 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=152129&action=review

> Tools/Scripts/webkitpy/common/message_pool.py:284
> +            _log.error("%s: %s('%s') raised:" % (
> +                    self.name, exception_value.__class__.__name__, str(exception_value)))

Nit: I think this would be easier to read on one long line.

[Dirk Pranke]

(In reply to comment #4)
> (From update of attachment 152129 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=152129&action=review
> 
> > Tools/Scripts/webkitpy/common/message_pool.py:284
> > +            _log.error("%s: %s('%s') raised:" % (
> > +                    self.name, exception_value.__class__.__name__, str(exception_value)))
> 
> Nit: I think this would be easier to read on one long line.

You're right. Done.

[Dirk Pranke]

Committed r122615: <http://trac.webkit.org/changeset/122615>

[Thiago Marcos P. Santos]

This patch makes the runner returns a error code when it succeeds. I have a fix for it at bug 91370.