Summary: | NRWT doesn't print exceptions | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Xianzhu Wang <wangxianzhu> | ||||
Component: | Tools / Tests | Assignee: | Dirk Pranke <dpranke> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | abarth, dpranke, ojan, tmpsantos, tony, webkit.review.bot | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Bug Depends on: | 91370 | ||||||
Bug Blocks: | |||||||
Attachments: |
|
Description
Xianzhu Wang
2012-07-12 11:50:16 PDT
Created attachment 152129 [details]
Patch
Attachment 152129 [details] did not pass style-queue:
Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Tools/ChangeLog', u'Tools/Scripts/webkitpy..." exit_code: 1
Tools/Scripts/webkitpy/common/message_pool.py:277: deprecated form of raising exception [pep8/W602] [5]
Total errors found: 1 in 4 files
If any of these errors are false positives, please file a bug against check-webkit-style.
(In reply to comment #2) > Attachment 152129 [details] did not pass style-queue: > > Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Tools/ChangeLog', u'Tools/Scripts/webkitpy..." exit_code: 1 > Tools/Scripts/webkitpy/common/message_pool.py:277: deprecated form of raising exception [pep8/W602] [5] > Total errors found: 1 in 4 files > > > If any of these errors are false positives, please file a bug against check-webkit-style. This style error is unavoidable and can be ignored. Comment on attachment 152129 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=152129&action=review > Tools/Scripts/webkitpy/common/message_pool.py:284 > + _log.error("%s: %s('%s') raised:" % ( > + self.name, exception_value.__class__.__name__, str(exception_value))) Nit: I think this would be easier to read on one long line. (In reply to comment #4) > (From update of attachment 152129 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=152129&action=review > > > Tools/Scripts/webkitpy/common/message_pool.py:284 > > + _log.error("%s: %s('%s') raised:" % ( > > + self.name, exception_value.__class__.__name__, str(exception_value))) > > Nit: I think this would be easier to read on one long line. You're right. Done. Committed r122615: <http://trac.webkit.org/changeset/122615> |