Summary: | [BlackBerry] Update about:* pages | ||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Joshua Netterfield <jnetterfield> | ||||||||||||
Component: | WebKit BlackBerry | Assignee: | Nobody <webkit-unassigned> | ||||||||||||
Status: | RESOLVED FIXED | ||||||||||||||
Severity: | Normal | CC: | mifenton, tonikitoo, webkit.review.bot, yong.li.webkit | ||||||||||||
Priority: | P2 | ||||||||||||||
Version: | 528+ (Nightly build) | ||||||||||||||
Hardware: | Unspecified | ||||||||||||||
OS: | Unspecified | ||||||||||||||
Attachments: |
|
Description
Joshua Netterfield
2012-07-12 11:09:08 PDT
Created attachment 152032 [details]
Patch
Created attachment 152038 [details]
Patch
Comment on attachment 152038 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=152038&action=review > Source/WebKit/blackberry/WebCoreSupport/AboutData.cpp:47 > +static int strcmpNatural(const char *a, const char *b) > +{ > + for (; *a == *b && *a; ++a, ++b) { } > + if (*a >= '0' && *a <= '9' && *b >= 'A') > + return 1; > + if (*b >= '0' && *b <= '9' && *a >= 'A') > + return -1; > + return *b - *a; > +} Can you add some description for this function? Created attachment 152043 [details]
Patch
Created attachment 152049 [details]
Patch
Comment on attachment 152049 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=152049&action=review r+ with the copyright line fixed > Source/WebKit/blackberry/WebCoreSupport/AboutTemplate.html.cpp:3 > + * Copyright (C) 2010, 2011 Research In Motion Limited. All rights reserved. > + * should include 2012? Created attachment 152239 [details]
Patch
Comment on attachment 152239 [details] Patch Clearing flags on attachment: 152239 Committed r122573: <http://trac.webkit.org/changeset/122573> All reviewed patches have been landed. Closing bug. |