Bug 91100

Summary: [GTK] Add API to get HTTPS status to WebKit2 GTK+
Product: WebKit Reporter: Carlos Garcia Campos <cgarcia>
Component: WebKit2Assignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: danw, gns, mrobinson, rakuco, svillar, webkit.review.bot, xan.lopez
Priority: P2 Keywords: Gtk, Soup
Version: 528+ (Nightly build)   
Hardware: PC   
OS: Linux   
Attachments:
Description Flags
Patch mrobinson: review+

Description Carlos Garcia Campos 2012-07-12 08:42:51 PDT
Add webkit_uri_response_get_https_status() similar to soup_message_get_https_status().
Comment 1 Carlos Garcia Campos 2012-07-12 08:54:57 PDT
Created attachment 151967 [details]
Patch

This patch doesn't depend on bug #90267. It implements PlatformCertificateInfo for soup and adds API to get the HTTPS status from the WebKitURIResponse.
Comment 2 WebKit Review Bot 2012-07-12 08:59:13 PDT
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API
Comment 3 WebKit Review Bot 2012-07-12 08:59:33 PDT
Attachment 151967 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WTF/ChangeLog', u'Source/WTF/wtf/go..." exit_code: 1
Source/WebKit2/UIProcess/API/gtk/tests/WebKitTestServer.cpp:41:  Use 0 instead of NULL.  [readability/null] [5]
Source/WebKit2/Shared/soup/PlatformCertificateInfo.cpp:93:  Use 0 instead of NULL.  [readability/null] [5]
WARNING: File exempt from style guide. Skipping: "Source/WebKit2/UIProcess/API/gtk/WebKitURIResponse.h"
Total errors found: 2 in 24 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 4 Martin Robinson 2012-07-12 09:06:30 PDT
Comment on attachment 151967 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=151967&action=review

> Source/WebKit2/UIProcess/API/gtk/tests/WebKitTestServer.cpp:26
> +WebKitTestServer::WebKitTestServer(bool ssl)

I think it would be nice to use an enum here, so that instantiating a server looks like this:

WebKitTestServer(EnableSSL)

or something similar.
Comment 5 Carlos Garcia Campos 2012-07-13 00:26:36 PDT
Committed r122547: <http://trac.webkit.org/changeset/122547>