Summary: | Web Inspector: beautify find bar looks, simplify search update routines. | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Pavel Feldman <pfeldman> | ||||||||
Component: | Web Inspector (Deprecated) | Assignee: | Pavel Feldman <pfeldman> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | apavlov, bweinstein, joepeck, keishi, loislo, pfeldman, pmuellr, rik, timothy, yurys | ||||||||
Priority: | P2 | ||||||||||
Version: | 528+ (Nightly build) | ||||||||||
Hardware: | All | ||||||||||
OS: | All | ||||||||||
Attachments: |
|
Description
Pavel Feldman
2012-07-12 06:20:22 PDT
Created attachment 151935 [details]
[IMAGE] Screenshot with patch applied.
Created attachment 151937 [details]
Patch
Comment on attachment 151937 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=151937&action=review > Source/WebCore/inspector/front-end/SearchController.js:41 > + labelElement.textContent = "Find"; UIString? Comment on attachment 151937 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=151937&action=review > Source/WebCore/inspector/front-end/SearchController.js:-249 > - if (!isEnterKey(event)) Incremental search works weirdly now - it jumps to the next occurrence each time you add a letter even if current occurrence matches new query. I believe this code was needed. Created attachment 151943 [details]
Patch
Comment on attachment 151943 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=151943&action=review > Source/WebCore/inspector/front-end/SearchController.js:240 > + _performSearch: function(query, forceSearch, isBackwardSearch) Please annotate all parameters. Committed r122465: <http://trac.webkit.org/changeset/122465> |