Summary: | REGRESSION(r122358): Build break on WebKit Win (Requested by hayato on #webkit). | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | WebKit Review Bot <webkit.review.bot> | ||||
Component: | New Bugs | Assignee: | WebKit Review Bot <webkit.review.bot> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | abarth, hayato, tony | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Bug Depends on: | |||||||
Bug Blocks: | 90996 | ||||||
Attachments: |
|
Description
WebKit Review Bot
2012-07-11 17:45:28 PDT
Created attachment 151826 [details] ROLLOUT of r122358 Any committer can land this patch automatically by marking it commit-queue+. The commit-queue will build and test the patch before landing to ensure that the rollout will be successful. This process takes approximately 15 minutes. If you would like to land the rollout faster, you can use the following command: webkit-patch land-attachment ATTACHMENT_ID where ATTACHMENT_ID is the ID of this attachment. WebKit Win builder started to fail after r27168. Build Log: http://build.chromium.org/p/chromium.webkit/builders/Webkit%20Win%20Builder/builds/27168 11> webview_host_win.cc 11>tools\test_shell\drop_delegate.cc(35): error C2660: 'WebKit::WebView::dragTargetDragEnter' : function does not take 4 arguments 11>tools\test_shell\drop_delegate.cc(50): error C2660: 'WebKit::WebView::dragTargetDragOver' : function does not take 3 arguments 11>tools\test_shell\drop_delegate.cc(68): error C2660: 'WebKit::WebView::dragTargetDrop' : function does not take 2 arguments 11> 11>Build FAILED. I guess we have to update webview_host_win.cc also. Let me roll out r122358 for safety. Comment on attachment 151826 [details] ROLLOUT of r122358 Clearing flags on attachment: 151826 Committed r122395: <http://trac.webkit.org/changeset/122395> All reviewed patches have been landed. Closing bug. Sorry about that, thanks for rolling out. |