WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
91037
REGRESSION(
r122358
): Build break on WebKit Win (Requested by hayato on #webkit).
https://bugs.webkit.org/show_bug.cgi?id=91037
Summary
REGRESSION(r122358): Build break on WebKit Win (Requested by hayato on #webkit).
WebKit Review Bot
Reported
2012-07-11 17:45:28 PDT
http://trac.webkit.org/changeset/122358
broke the build: Build break on WebKit Win (Requested by hayato on #webkit). This is an automatic bug report generated by the sheriff-bot. If this bug report was created because of a flaky test, please file a bug for the flaky test (if we don't already have one on file) and dup this bug against that bug so that we can track how often these flaky tests case pain. "Only you can prevent forest fires." -- Smokey the Bear
Attachments
ROLLOUT of r122358
(9.07 KB, patch)
2012-07-11 17:46 PDT
,
WebKit Review Bot
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
WebKit Review Bot
Comment 1
2012-07-11 17:46:07 PDT
Created
attachment 151826
[details]
ROLLOUT of
r122358
Any committer can land this patch automatically by marking it commit-queue+. The commit-queue will build and test the patch before landing to ensure that the rollout will be successful. This process takes approximately 15 minutes. If you would like to land the rollout faster, you can use the following command: webkit-patch land-attachment ATTACHMENT_ID where ATTACHMENT_ID is the ID of this attachment.
Hayato Ito
Comment 2
2012-07-11 17:50:06 PDT
WebKit Win builder started to fail after
r27168
. Build Log:
http://build.chromium.org/p/chromium.webkit/builders/Webkit%20Win%20Builder/builds/27168
11> webview_host_win.cc 11>tools\test_shell\drop_delegate.cc(35): error C2660: 'WebKit::WebView::dragTargetDragEnter' : function does not take 4 arguments 11>tools\test_shell\drop_delegate.cc(50): error C2660: 'WebKit::WebView::dragTargetDragOver' : function does not take 3 arguments 11>tools\test_shell\drop_delegate.cc(68): error C2660: 'WebKit::WebView::dragTargetDrop' : function does not take 2 arguments 11> 11>Build FAILED. I guess we have to update webview_host_win.cc also. Let me roll out
r122358
for safety.
WebKit Review Bot
Comment 3
2012-07-11 17:54:26 PDT
Comment on
attachment 151826
[details]
ROLLOUT of
r122358
Clearing flags on attachment: 151826 Committed
r122395
: <
http://trac.webkit.org/changeset/122395
>
WebKit Review Bot
Comment 4
2012-07-11 17:54:31 PDT
All reviewed patches have been landed. Closing bug.
Tony Chang
Comment 5
2012-07-11 18:03:07 PDT
Sorry about that, thanks for rolling out.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug