Bug 91018

Summary: Failure to dispatch didFinishLoadForFrame if font load fails synchronously
Product: WebKit Reporter: Antti Koivisto <koivisto>
Component: Page LoadingAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: beidson, cmarcelo, ddkilzer, macpherson, menard, mitz, psolanki, webkit.review.bot
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
patch enrica: review+

Description Antti Koivisto 2012-07-11 14:40:20 PDT
If a font load fails synchronously (by willSendRequest delegate) we might fail to dispatch didFinishLoadForFrame.
Normally checkLoadComplete would be invoked by DocumentLoader::removeSubresourceLoader but in case of a synchronous failure
add/removeSubresourceLoader is not called at all.
Comment 1 Antti Koivisto 2012-07-11 14:41:57 PDT
<rdar://problem/11822378>
Comment 2 Antti Koivisto 2012-07-11 15:07:28 PDT
Created attachment 151793 [details]
patch

I'll see about making an API test though conditions where this occur a fairly specific.
Comment 3 Pratik Solanki 2012-07-11 15:29:41 PDT
Comment on attachment 151793 [details]
patch

Looks good to me.
Comment 4 Enrica Casucci 2012-07-11 17:40:49 PDT
Comment on attachment 151793 [details]
patch

This looks good to me.
Comment 5 Antti Koivisto 2012-07-12 04:41:46 PDT
http://trac.webkit.org/changeset/122446