Bug 91002

Summary: WebPage::touchEvent() should use Platform::TouchEvent's toString() for debugging.
Product: WebKit Reporter: Pawel Chomicki <pchomicki>
Component: WebKit BlackBerryAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: mifenton, tonikitoo, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch with ChangeLog
none
Patch with ChangeLog
none
Patch with ChangeLog
rwlbuis: review+
Patch with ChangeLog
rwlbuis: review+, webkit.review.bot: commit-queue-
Patch with ChangeLog
none
Patch with ChangeLog none

Description Pawel Chomicki 2012-07-11 12:52:20 PDT
toString() provide's a more thorough description of the TouchEvent and is more useful for debugging purposes.
Comment 1 Pawel Chomicki 2012-07-11 13:02:20 PDT
Created attachment 151756 [details]
Patch with ChangeLog
Comment 2 Pawel Chomicki 2012-07-11 14:10:38 PDT
Created attachment 151771 [details]
Patch with ChangeLog

Previous patch was missing 'reviewed by' line in git log and ChangeLog.
Comment 3 Pawel Chomicki 2012-07-11 14:15:34 PDT
Created attachment 151773 [details]
Patch with ChangeLog

Forgot to git add ChangeLog file.
Comment 4 Rob Buis 2012-07-11 14:17:45 PDT
Comment on attachment 151773 [details]
Patch with ChangeLog

LGTM.
Comment 5 Pawel Chomicki 2012-07-11 14:37:01 PDT
Created attachment 151782 [details]
Patch with ChangeLog
Comment 6 Rob Buis 2012-07-11 15:09:46 PDT
Comment on attachment 151782 [details]
Patch with ChangeLog

LGTM.
Comment 7 WebKit Review Bot 2012-07-11 15:15:52 PDT
Comment on attachment 151782 [details]
Patch with ChangeLog

Rejecting attachment 151782 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2

Last 500 characters of output:
ode: 1 cwd: /mnt/git/webkit-commit-queue/

Parsed 2 diffs from patch file(s).
patching file Source/WebKit/blackberry/Api/WebPage.cpp
Hunk #1 succeeded at 4124 (offset -15 lines).
patching file Source/WebKit/blackberry/ChangeLog
Hunk #1 FAILED at 1.
1 out of 1 hunk FAILED -- saving rejects to file Source/WebKit/blackberry/ChangeLog.rej

Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--force', u'--reviewer', u'Rob Buis']" exit_code: 1 cwd: /mnt/git/webkit-commit-queue/

Full output: http://queues.webkit.org/results/13208477
Comment 8 Pawel Chomicki 2012-07-11 17:23:06 PDT
Created attachment 151821 [details]
Patch with ChangeLog
Comment 9 Pawel Chomicki 2012-07-12 08:28:21 PDT
Created attachment 151963 [details]
Patch with ChangeLog
Comment 10 WebKit Review Bot 2012-07-12 09:36:14 PDT
Comment on attachment 151963 [details]
Patch with ChangeLog

Clearing flags on attachment: 151963

Committed r122469: <http://trac.webkit.org/changeset/122469>
Comment 11 WebKit Review Bot 2012-07-12 09:36:19 PDT
All reviewed patches have been landed.  Closing bug.