| Summary: | Style Error in WebPage.cpp | ||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Pawel Chomicki <pchomicki> | ||||||||||||
| Component: | WebKit BlackBerry | Assignee: | Nobody <webkit-unassigned> | ||||||||||||
| Status: | RESOLVED WONTFIX | ||||||||||||||
| Severity: | Normal | CC: | haraken, tonikitoo, webkit.review.bot | ||||||||||||
| Priority: | P2 | ||||||||||||||
| Version: | 528+ (Nightly build) | ||||||||||||||
| Hardware: | Unspecified | ||||||||||||||
| OS: | Unspecified | ||||||||||||||
| Attachments: |
|
||||||||||||||
|
Description
Pawel Chomicki
2012-07-11 11:26:21 PDT
Created attachment 151741 [details]
Patch with ChangeLog
maybe the patch does not apply against ToT? Comment on attachment 151741 [details] Patch with ChangeLog Rejecting attachment 151741 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: e: 1 cwd: /mnt/git/webkit-commit-queue/ Parsed 2 diffs from patch file(s). patching file Source/WebKit/blackberry/Api/WebPage.cpp Hunk #1 FAILED at 5642. 1 out of 1 hunk FAILED -- saving rejects to file Source/WebKit/blackberry/Api/WebPage.cpp.rej patching file Source/WebKit/blackberry/ChangeLog Hunk #1 succeeded at 1 with fuzz 3. Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--force', u'--reviewer', u'Antonio Go..." exit_code: 1 cwd: /mnt/git/webkit-commit-queue/ Full output: http://queues.webkit.org/results/13208418 Created attachment 151749 [details]
Patch with ChangeLog
My apologies, I had forgotten to rebase the repository before writing my changes, which causes some errors when patching the changelog. This latest patch should work, however.
Comment on attachment 151749 [details]
Patch with ChangeLog
LGTM.
Comment on attachment 151749 [details]
Patch with ChangeLog
rebase your commit
Created attachment 151779 [details]
Patch with ChangeLog
Created attachment 151781 [details]
Patch with ChangeLog
Comment on attachment 151781 [details]
Patch with ChangeLog
LGTM.
Comment on attachment 151781 [details] Patch with ChangeLog Rejecting attachment 151781 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: code: 1 cwd: /mnt/git/webkit-commit-queue/ Parsed 2 diffs from patch file(s). patching file Source/WebKit/blackberry/Api/WebPage.cpp Hunk #1 FAILED at 5760. 1 out of 1 hunk FAILED -- saving rejects to file Source/WebKit/blackberry/Api/WebPage.cpp.rej patching file Source/WebKit/blackberry/ChangeLog Hunk #1 succeeded at 1 with fuzz 3. Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--force', u'--reviewer', u'Rob Buis']" exit_code: 1 cwd: /mnt/git/webkit-commit-queue/ Full output: http://queues.webkit.org/results/13207404 Created attachment 151819 [details]
Patch with ChangeLog
(Though I am not intending to say a strong opinion since this is a blackberry patch, FYI,) basically WebKit does not accept only-style-fix patches, which just messes up history. (In reply to comment #12) > (Though I am not intending to say a strong opinion since this is a blackberry patch, FYI,) basically WebKit does not accept only-style-fix patches, which just messes up history. Agree. Please fix it as part of another patch, or when effectively touching this piece of code. |