Bug 90948

Summary: [EFL] Move tests that require ENABLE_INPUT_TYPE_* to TestExpectations
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: WebKit EFLAssignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: gyuyoung.kim, lucas.de.marchi, rakuco, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
cdumez: commit-queue-
Patch
none
Patch
none
Patch
none
Patch
none
Patch none

Description Chris Dumez 2012-07-11 00:47:24 PDT 
The fast/forms/input-in-table-cell-no-value.html introduced in r122290 is failing on EFL port because ENABLE_INPUT_TYPE_DATE flag is not enabled on EFL port.
Comment 1 Chris Dumez 2012-07-11 00:49:38 PDT 
Created attachment 151626 [details]
Patch

Could someone please cq+ ?
Comment 2 Chris Dumez 2012-07-11 00:52:06 PDT 
Created attachment 151629 [details]
Patch

Fix bug number.
Comment 3 Chris Dumez 2012-07-11 00:55:21 PDT 
Just received feedback from Bug 89209 that the date input might not be the issue for this failure after all. Marking cq- until we have a better understanding.
Comment 4 Chris Dumez 2012-07-11 00:58:42 PDT 
Created attachment 151631 [details]
Patch

Move only the other tests to TestExpectations for now.
Comment 5 Chris Dumez 2012-07-11 01:00:06 PDT 
Created attachment 151632 [details]
Patch

Fix typo.
Comment 6 Chris Dumez 2012-07-11 01:01:13 PDT 
Created attachment 151633 [details]
Patch
Comment 7 Chris Dumez 2012-07-11 01:05:00 PDT 
Created attachment 151635 [details]
Patch

Ok, now it was agreed in Bug 89209 that the new test should be skipped as well.
Comment 8 Chris Dumez 2012-07-11 01:06:18 PDT 
Created attachment 151638 [details]
Patch
Comment 9 WebKit Review Bot 2012-07-11 02:07:14 PDT 
Comment on attachment 151638 [details]
Patch

Clearing flags on attachment: 151638

Committed r122314: <http://trac.webkit.org/changeset/122314>
Comment 10 WebKit Review Bot 2012-07-11 02:07:25 PDT 
All reviewed patches have been landed.  Closing bug.