Summary: | Line directive test in fast/canvas/webgl/glsl-conformance.html is incorrect | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Kenneth Russell <kbr> | ||||||
Component: | WebGL | Assignee: | Kenneth Russell <kbr> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | dino, enne, gman, mrobinson, noam, webkit.review.bot, zmo | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | All | ||||||||
OS: | All | ||||||||
Attachments: |
|
Description
Kenneth Russell
2012-07-10 11:21:17 PDT
It turns out that this test is invalid (it is making assertions about the GLSL compiler's output not guaranteed by the spec). It's been removed from the WebGL conformance suite; we can just remove the test. Created attachment 151529 [details]
Patch
Comment on attachment 151529 [details]
Patch
R=me. Looks fine to me, but sad that the spec isn't testable. :(
Created attachment 151537 [details]
Patch for landing
Comment on attachment 151537 [details] Patch for landing Clearing flags on attachment: 151537 Committed r122281: <http://trac.webkit.org/changeset/122281> All reviewed patches have been landed. Closing bug. |