Bug 90897

Summary: Line directive test in fast/canvas/webgl/glsl-conformance.html is incorrect
Product: WebKit Reporter: Kenneth Russell <kbr>
Component: WebGLAssignee: Kenneth Russell <kbr>
Status: RESOLVED FIXED    
Severity: Normal CC: dino, enne, gman, mrobinson, noam, webkit.review.bot, zmo
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch
none
Patch for landing none

Kenneth Russell
Reported 2012-07-10 11:21:17 PDT
Alok Priyadarshi has recently rewritten the preprocessor in the ANGLE shader translator, and the rewrite has turned up a bug in the fast/canvas/webgl/glsl-conformance.html test of vshaderWithLineDirective. The test assumes that the error will occur on line 124, but according to the GLSL ES specification it should occur on line 123. I am going to update the test to be correct and skip it on the majority of platforms. As ANGLE is updated in various ports to pick up the new preprocessor, the test can be enabled again.
Attachments
Patch (3.73 KB, patch)
2012-07-10 14:51 PDT, Kenneth Russell 		no flags
DetailsFormatted DiffDiff
Patch for landing (3.83 KB, patch)
2012-07-10 15:09 PDT, Kenneth Russell 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Kenneth Russell
Comment 1 2012-07-10 14:48:18 PDT
It turns out that this test is invalid (it is making assertions about the GLSL compiler's output not guaranteed by the spec). It's been removed from the WebGL conformance suite; we can just remove the test.
Kenneth Russell
Comment 2 2012-07-10 14:51:14 PDT
Created attachment 151529 [details] Patch
Adrienne Walker
Comment 3 2012-07-10 14:52:33 PDT
Comment on attachment 151529 [details] Patch R=me. Looks fine to me, but sad that the spec isn't testable. :(
Kenneth Russell
Comment 4 2012-07-10 15:09:40 PDT
Created attachment 151537 [details] Patch for landing
WebKit Review Bot
Comment 5 2012-07-10 17:18:53 PDT
Comment on attachment 151537 [details] Patch for landing Clearing flags on attachment: 151537 Committed r122281: <http://trac.webkit.org/changeset/122281>
WebKit Review Bot
Comment 6 2012-07-10 17:18:58 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.