Bug 90868

Summary: [EFL] WebKit DRT and WTR fail to build due to undefined reference to WTF::MD5::*
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: WebKit EFLAssignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: gyuyoung.kim, lucas.de.marchi, naginenis, rakuco, tmpsantos, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Description Chris Dumez 2012-07-10 03:23:39 PDT 
We get the following linking errors on the EFL build bot:

CMakeFiles/DumpRenderTree.dir/__/cairo/PixelDumpSupportCairo.cpp.o: In function `computeMD5HashStringForBitmapContext(BitmapContext*, char*)':
/home/buildslave-1/webkit-buildslave/efl-linux-64-debug/build/Tools/DumpRenderTree/cairo/PixelDumpSupportCairo.cpp:75: undefined reference to `WTF::MD5::MD5()'
/home/buildslave-1/webkit-buildslave/efl-linux-64-debug/build/Tools/DumpRenderTree/cairo/PixelDumpSupportCairo.cpp:78: undefined reference to `WTF::MD5::addBytes(unsigned char const*, unsigned long)'
/home/buildslave-1/webkit-buildslave/efl-linux-64-debug/build/Tools/DumpRenderTree/cairo/PixelDumpSupportCairo.cpp:82: undefined reference to `WTF::MD5::checksum(WTF::Vector<unsigned char, 16ul>&)'
collect2: ld returned 1 exit status
Comment 1 Chris Dumez 2012-07-10 03:29:11 PDT 
Created attachment 151427 [details]
Patch

Could someone please validate and cq+ ?
Comment 2 Raphael Kubo da Costa (:rakuco) 2012-07-10 03:39:34 PDT 
Comment on attachment 151427 [details]
Patch

Looks sane, it looks like I shouldn't have removed ${WTF_LIBRARY_NAME} in r109983...
Comment 3 WebKit Review Bot 2012-07-10 05:03:09 PDT 
Comment on attachment 151427 [details]
Patch

Clearing flags on attachment: 151427

Committed r122213: <http://trac.webkit.org/changeset/122213>
Comment 4 WebKit Review Bot 2012-07-10 05:03:14 PDT 
All reviewed patches have been landed.  Closing bug.