Bug 90863 – [Qt][V8] Remove the V8 related codepaths and configuration

• Component: WebKit Qt
• Status: RESOLVED FIXED

[Andras Becsi]

Since the conclusion was to discontinue the effort for QtWebKit-V8 (http://lists.webkit.org/pipermail/webkit-qt/2012-June/thread.html#2871) we should remove all the codepaths and configuration options which were introduced for building with V8.

[Balazs Kelemen]

Burn!

[Balazs Kelemen]

These guys want to see the show too :D

[Balazs Kelemen]

Gabor has started working on this.

[Gabor Ballabas]

Created attachment 152517 [details]
Patch

[WebKit Review Bot]

Comment on attachment 152517 [details]
Patch

Attachment 152517 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/13245885

[Simon Hausmann]

Comment on attachment 152517 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=152517&action=review

Looks good in general, a few small nitpicks

> Source/WebCore/DerivedSources.pri:621
> -v8: wrapperFactoryArg = --wrapperFactoryV8
> -else: wrapperFactoryArg = --wrapperFactory
> +wrapperFactoryArg = --wrapperFactory

You could eliminate the variable entirely I think

> Source/WebCore/DerivedSources.pri:638
>  svgnames.extra_sources = SVGElementFactory.cpp
> -v8 {
> -    svgnames.extra_sources += V8SVGElementWrapperFactory.cpp
> -} else {
>      svgnames.extra_sources += JSSVGElementWrapperFactory.cpp

You could merge line 637 and 638 or at least remove the indentation in 638 :)

> Source/WebCore/DerivedSources.pri:695
> +generator = JS

Same here, I think you could just get rid of the generator variable and pass --generator JS directly

[Simon Hausmann]

Comment on attachment 152517 [details]
Patch

r=me if you do the small fix-ups I suggested before landing.

[Kristóf Kosztyó]

Committed r122834: <http://trac.webkit.org/changeset/122834>

[WebKit Review Bot]

Re-opened since this is blocked by 91492

[Gabor Ballabas]

Created attachment 152737 [details]
Remove v8 from QtWebKit

[WebKit Review Bot]

Comment on attachment 152737 [details]
Remove v8 from QtWebKit

Rejecting attachment 152737 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 1

ERROR: /mnt/git/webkit-commit-queue/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive).

Full output: http://queues.webkit.org/results/13276141

[WebKit Review Bot]

Comment on attachment 152737 [details]
Remove v8 from QtWebKit

Clearing flags on attachment: 152737

Committed r122845: <http://trac.webkit.org/changeset/122845>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.