Bug 90853

Summary: Remove LayoutTestController and WebKitTestRunner support for Hixie76 WebSockets
Product: WebKit Reporter: Adam Barth <abarth>
Component: New BugsAssignee: Adam Barth <abarth>
Status: RESOLVED FIXED    
Severity: Normal CC: dglazkov, tkent, webkit.review.bot, yutak
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 81371    
Attachments:
Description Flags
Patch
none
Patch
none
Archive of layout-test-results from gce-cr-linux-05
none
Patch none

Adam Barth
Reported 2012-07-10 00:37:05 PDT
Remove LayoutTestController and WebKitTestRunner support for Hixie76 WebSockets
Attachments
Patch (8.39 KB, patch)
2012-07-10 00:38 PDT, Adam Barth 		no flags
DetailsFormatted DiffDiff
Patch (81.60 KB, patch)
2012-07-10 09:28 PDT, Adam Barth 		no flags
DetailsFormatted DiffDiff
Archive of layout-test-results from gce-cr-linux-05 (394.54 KB, application/zip)
2012-07-10 10:02 PDT, WebKit Review Bot 		no flags
Details
Patch (82.90 KB, patch)
2012-07-10 10:08 PDT, Adam Barth 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Adam Barth
Comment 1 2012-07-10 00:38:27 PDT
Created attachment 151409 [details] Patch
Yuta Kitamura
Comment 2 2012-07-10 00:44:36 PDT
Thank you for doing this! The patch looks good to me. (I'm not a reviewer so please have some other reviewer to review this.)
Kent Tamura
Comment 3 2012-07-10 01:17:01 PDT
Comment on attachment 151409 [details] Patch Looks good.
Kent Tamura
Comment 4 2012-07-10 04:53:06 PDT
Comment on attachment 151409 [details] Patch Tests still have testRunner.overridePreference("WebKitHixie76WebSocketProtocolEnabled", 0), and it produces a console message if the patch is applied.
Adam Barth
Comment 5 2012-07-10 08:05:40 PDT
Ah, will fix.
Adam Barth
Comment 6 2012-07-10 09:28:50 PDT
Created attachment 151468 [details] Patch
WebKit Review Bot
Comment 7 2012-07-10 10:02:34 PDT
Comment on attachment 151468 [details] Patch Attachment 151468 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/13209018 New failing tests: http/tests/inspector/websocket/web-socket-frame.html http/tests/inspector/web-socket-frame-error.html
WebKit Review Bot
Comment 8 2012-07-10 10:02:38 PDT
Created attachment 151475 [details] Archive of layout-test-results from gce-cr-linux-05 The attached test failures were seen while running run-webkit-tests on the chromium-ews. Bot: gce-cr-linux-05 Port: <class 'webkitpy.common.config.ports.ChromiumXVFBPort'> Platform: Linux-2.6.39-gcg-201203291735-x86_64-with-Ubuntu-10.04-lucid
Adam Barth
Comment 9 2012-07-10 10:08:10 PDT
Created attachment 151479 [details] Patch
WebKit Review Bot
Comment 10 2012-07-10 13:40:07 PDT
Comment on attachment 151479 [details] Patch Clearing flags on attachment: 151479 Committed r122256: <http://trac.webkit.org/changeset/122256>
WebKit Review Bot
Comment 11 2012-07-10 13:40:11 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.