Summary: | Remove LayoutTestController and WebKitTestRunner support for Hixie76 WebSockets | ||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Adam Barth <abarth> | ||||||||||
Component: | New Bugs | Assignee: | Adam Barth <abarth> | ||||||||||
Status: | RESOLVED FIXED | ||||||||||||
Severity: | Normal | CC: | dglazkov, tkent, webkit.review.bot, yutak | ||||||||||
Priority: | P2 | ||||||||||||
Version: | 528+ (Nightly build) | ||||||||||||
Hardware: | Unspecified | ||||||||||||
OS: | Unspecified | ||||||||||||
Bug Depends on: | |||||||||||||
Bug Blocks: | 81371 | ||||||||||||
Attachments: |
|
Description
Adam Barth
2012-07-10 00:37:05 PDT
Created attachment 151409 [details]
Patch
Thank you for doing this! The patch looks good to me. (I'm not a reviewer so please have some other reviewer to review this.) Comment on attachment 151409 [details]
Patch
Looks good.
Comment on attachment 151409 [details]
Patch
Tests still have testRunner.overridePreference("WebKitHixie76WebSocketProtocolEnabled", 0), and it produces a console message if the patch is applied.
Ah, will fix. Created attachment 151468 [details]
Patch
Comment on attachment 151468 [details] Patch Attachment 151468 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/13209018 New failing tests: http/tests/inspector/websocket/web-socket-frame.html http/tests/inspector/web-socket-frame-error.html Created attachment 151475 [details]
Archive of layout-test-results from gce-cr-linux-05
The attached test failures were seen while running run-webkit-tests on the chromium-ews.
Bot: gce-cr-linux-05 Port: <class 'webkitpy.common.config.ports.ChromiumXVFBPort'> Platform: Linux-2.6.39-gcg-201203291735-x86_64-with-Ubuntu-10.04-lucid
Created attachment 151479 [details]
Patch
Comment on attachment 151479 [details] Patch Clearing flags on attachment: 151479 Committed r122256: <http://trac.webkit.org/changeset/122256> All reviewed patches have been landed. Closing bug. |