Bug 90785

Summary:

[EFL][UT] Delete shutdown method.

Product:

WebKit

Reporter:

Krzysztof Czech <k.czech>

Component:

WebKit EFL

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

g.czajkowski, gyuyoung.kim, lucas.de.marchi, rakuco, sw0524.lee, tmpsantos, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Linux

Attachments:

Description	Flags
shutdown method is not needed.	none

Krzysztof Czech

Reported 2012-07-09 06:26:31 PDT

Delete shutdown method from EWKTestBase class.

Attachments
shutdown method is not needed. (1.84 KB, patch) 2012-07-09 06:30 PDT, Krzysztof Czech	no flags	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Krzysztof Czech

Comment 1 2012-07-09 06:30:27 PDT

Created attachment 151245 [details] shutdown method is not needed.

Thiago Marcos P. Santos

Comment 2 2012-07-11 04:51:38 PDT

LGTM.

Gyuyoung Kim

Comment 3 2012-07-11 08:53:32 PDT

Comment on attachment 151245 [details] shutdown method is not needed. Looks fine. BTW, in my humble opinion, isn't it better to use shutdown() instead of shutdownAll() in order to be in sync with init() ?

Krzysztof Czech

Comment 4 2012-07-12 00:48:42 PDT

(In reply to comment #3) > (From update of attachment 151245 [details]) > Looks fine. BTW, in my humble opinion, isn't it better to use shutdown() instead of shutdownAll() in order to be in sync with init() ? I will take a look at it, thanks

Raphael Kubo da Costa (:rakuco)

Comment 5 2012-07-12 13:05:55 PDT

I disagree with this approach for the same reason I mentioned in <https://bugs.webkit.org/show_bug.cgi?id=90606#c7>: you shouldn't need to loop to call the shutdown() functions; if you called _init() once, you should need to call _shutdown() only once. If it doesn't return 0, there's some unbalanced call somewhere.

Eric Seidel (no email)

Comment 6 2012-08-12 03:39:06 PDT

Comment on attachment 151245 [details] shutdown method is not needed. rs=me.

WebKit Review Bot

Comment 7 2012-08-12 04:26:19 PDT

Comment on attachment 151245 [details] shutdown method is not needed. Clearing flags on attachment: 151245 Committed r125369: <http://trac.webkit.org/changeset/125369>

WebKit Review Bot

Comment 8 2012-08-12 04:26:24 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.